72016 - Hard crashing scrolling tree widget in Add Bookmarks dialog

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P2)

Description

[Simon Fraser [no longer active]]

I crash hard when using the tree widget in the Add Bookmarks dialog. I have a 
bookmarks file that is pretty close to the default (only 1-2 user-added 
bookmarks). I 'Add Bookmark' on a page, and the dialog comes up. Then, expanding 
folders in the tree, and scrolling with teh scrollbar, can cause the machine to 
freeze. I also saw a freeze a previous time on cancelling the dialog, after 
manipulating the tree widget.

This sounds somewhat like a problem in the news subscribe dialog, which is a 
heap-trashing bug, possibly because of running out of stack space. There might be 
a generic 'trees in dialog' problem here.

Comment 1

[Simon Fraser [no longer active]]

Critical severity, since this is a machine-wide data loss crasher.

Comment 2

[Simon Fraser [no longer active]]

Attachment: MacsBug stack (yes, it really is that long)

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

Seth, Navin, this could be related to bug 48409...

Comment 4

[Paul Chen]

Marking nsbeta1+, p2, mozilla0.9

Comment 5

[Chris McAfee]

This wfm on linux.

Comment 6

[Simon Fraser [no longer active]]

So my blowing the stack theory is likely correct.

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

hrm, this could be a tree bug. 

Comment 8

[David Hyatt]

This is a known ancient bug in boxes where boxes keep telling trees to be bigger
than smaller than bigger than smaller, etc., which makes the tree create,
reflow, destroy, reflow, create, reflow, ad infinitum.

It comes up only on the Macintosh and can usually be alleviated by avoiding
hardcoded heights on two objects in a vertical box.

My 0.9 list is already out of control, so I can't fix this for 0.9.  I would
recommend looking for a workaround in the XUL if you need it fixed before 0.9.

Another option is to convert away from <tree> to <outliner>, which is
essentially fully ready at this point.

Comment 9

[David Hyatt]

Reassigning to evaughan.  When pink and i last debugged this, it looked like a
box rounding error.

Comment 10

[David Hyatt]

--> evaughan

Comment 11

[Simon Fraser [no longer active]]

Can we belt-and-braces to ensure that we never blow the stack (track recursion 
depth)? Layout does this.

Comment 12

[Sean Richardson]

Bug 73336, previously summarized as "Adding bookmarks goes into infinite 
recursion", is now "Put recursion defense into trees", targeted Moz 1.1, 
on Hyatt's list. Same problem, same solution, same bug?

Comment 13

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 14

[Blake Ross]

reassigning to me. if this is still happening, converting the add bookmarks 
dialog to outliner will fix it.

Comment 15

[Blake Ross]

fixed.

Comment 16

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]