720180 - console.log("foo"); console.error("foo"); should not be considered as a repeat.

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Paul Rouget [:paul]]

The red repeat counter is displayed and the 2 messages are folded as one. But they are not of the same nature.

Comment 1

[Sonny Piers [:sonny]]

I can't reproduce.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Sonny Piers [:sonny] from comment #1)
> I can't reproduce.

Just type "console.log("foo"); console.error("foo")" in the command line (add curly brackets if using GCLI). I think the check in ConsoleUtils_filterRepeatedConsole should take the icon into account as well.

Comment 3

[Mihai Sucan [:msucan]]

Bug triage. Filter on PEGASUS.

Comment 4

[Mihai Sucan [:msucan]]

Attachment: proposed patch

This patch makes repeated messages occur less often. We were merging messages too often - see the test for a few odd cases.

Comment 5

[Mihai Sucan [:msucan]]

This blocks a test from running correctly in bug 808370.

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 708684 [details] [diff] [review]
proposed patch

Review of attachment 708684 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 7

[Mihai Sucan [:msucan]]

Thank you!

Landed:
https://hg.mozilla.org/integration/fx-team/rev/cb07ba024a16

Comment 8

[Mihai Sucan [:msucan]]

Attachment: quick fix

It seems there's a test that puts unexpected messages in the web console output and it now fails sometimes. This patch should fix it.

Comment 9

[Mihai Sucan [:msucan]]

Attachment: quick fix 2

Thank you Panos!

Added a couple of checks for repeated node.

Landed:
https://hg.mozilla.org/integration/fx-team/rev/a02f96b9ef6f

Comment 10

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/cb07ba024a16
https://hg.mozilla.org/mozilla-central/rev/a02f96b9ef6f