console.log("foo"); console.error("foo"); should not be considered as a repeat.

RESOLVED FIXED in Firefox 21

Status

defect
P3
normal
RESOLVED FIXED
8 years ago
Last year

People

(Reporter: paul, Assigned: msucan)

Tracking

Trunk
Firefox 21
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Reporter

Description

8 years ago
The red repeat counter is displayed and the 2 messages are folded as one. But they are not of the same nature.
I can't reproduce.
Hardware: x86 → All
(In reply to Sonny Piers [:sonny] from comment #1)
> I can't reproduce.

Just type "console.log("foo"); console.error("foo")" in the command line (add curly brackets if using GCLI). I think the check in ConsoleUtils_filterRepeatedConsole should take the icon into account as well.
Assignee

Comment 3

8 years ago
Bug triage. Filter on PEGASUS.
Priority: -- → P3
Assignee

Updated

7 years ago
Assignee

Comment 4

7 years ago
This patch makes repeated messages occur less often. We were merging messages too often - see the test for a few odd cases.
Assignee: nobody → mihai.sucan
Status: NEW → ASSIGNED
Attachment #708684 - Flags: review?(past)
Assignee

Comment 5

7 years ago
This blocks a test from running correctly in bug 808370.
Blocks: 808370
Assignee

Updated

7 years ago
Blocks: 800510
Comment on attachment 708684 [details] [diff] [review]
proposed patch

Review of attachment 708684 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #708684 - Flags: review?(past) → review+
Assignee

Comment 7

7 years ago
Thank you!

Landed:
https://hg.mozilla.org/integration/fx-team/rev/cb07ba024a16
Whiteboard: [fixed-in-fx-team]
Assignee

Comment 8

7 years ago
Posted patch quick fix (obsolete) — Splinter Review
It seems there's a test that puts unexpected messages in the web console output and it now fails sometimes. This patch should fix it.
Attachment #710224 - Flags: review?(past)
Attachment #710224 - Flags: review?(past) → review+
Assignee

Comment 9

7 years ago
Posted patch quick fix 2Splinter Review
Thank you Panos!

Added a couple of checks for repeated node.

Landed:
https://hg.mozilla.org/integration/fx-team/rev/a02f96b9ef6f
Attachment #710224 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/cb07ba024a16
https://hg.mozilla.org/mozilla-central/rev/a02f96b9ef6f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 21

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.