720208 - Implement DOM4 DOMException types and codes

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Masatoshi Kimura [:emk]]

Attachment: patch

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 590555 [details] [diff] [review]
patch

I'll review this soon, but Ms2ger as a DOM4 editor could review this too.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 590555 [details] [diff] [review]
patch

Looks good to me.

>--- a/dom/base/domerr.msg
>+++ b/dom/base/domerr.msg
>+DOM_MSG_DEF_(INDEX_SIZE_ERR, "IndexSizeError", "Index or size is negative or greater than the allowed amount")
>+DOM_MSG_DEF_(DOMSTRING_SIZE_ERR, "DOMSTRING_SIZE_ERR", "The specified range of text does not fit in a DOM string")

I think it's weird to have "DOMSTRING_SIZE_ERR" here, even if that's not detectable from script. Could you make them title case for consistency?

Comment 3

[Masatoshi Kimura [:emk]]

Attachment: patch for check in; r=ms2ger, smaug

Thanks! Fixed casing.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 591761 [details] [diff] [review]
patch for check in; r=ms2ger, smaug

Er, I do want smaug to review it as well

Comment 5

[Masatoshi Kimura [:emk]]

(In reply to Ms2ger from comment #2)
> I think it's weird to have "DOMSTRING_SIZE_ERR" here, even if that's not
> detectable from script.
I found DOMSTRING_SIZE_ERR was still used:
https://mxr.mozilla.org/mozilla-central/source/content/base/src/nsGenericDOMDataNode.cpp#275
What should be done here?

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Oh, right. That should probably just be NS_ERROR_OUT_OF_MEMORY

Comment 7

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0e6b1dfaa99c

Comment 8

[Ed Morley [:emorley]]

Sorry had to back out for M1 orange:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=240237fb07cb

https://hg.mozilla.org/integration/mozilla-inbound/rev/738e02c121ae

Comment 9

[Masatoshi Kimura [:emk]]

Attachment: patch

Grrr, bug 682299 added yet another crossorigin test which caused the test failure.

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 593801 [details] [diff] [review]
patch

r=me on the additional test change

Comment 11

[Masatoshi Kimura [:emk]]

Do I need smaug's review either?

Comment 12

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I think that's fine.

Comment 13

[Masatoshi Kimura [:emk]]

Comment on attachment 593801 [details] [diff] [review]
patch

Setting the review flag again.

Comment 14

[Olli Pettay [:smaug][[e-mail]]]

What is the difference to the previous patch ?

Comment 15

[Masatoshi Kimura [:emk]]

Only 1 line change.
https://bugzilla.mozilla.org/attachment.cgi?oldid=591761&action=interdiff&newid=593801&headers=1

Comment 16

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 593801
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=9df4a628af5e
Try run started, revision 9df4a628af5e. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=9df4a628af5e

Comment 17

[Mozilla RelEng Bot]

Try run for 9df4a628af5e is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=9df4a628af5e
Results (out of 216 total builds):
    exception: 1
    success: 173
    warnings: 25
    failure: 17
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-9df4a628af5e

Comment 18

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/dce72d0fd6aa

Comment 19

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/dce72d0fd6aa

Comment 20

[Florian Scholz (Open Web Docs)]

Mentioned on
https://developer.mozilla.org/en/Firefox_13_for_developers#DOM
Updated
https://developer.mozilla.org/en/DOM/DOMException