745498 - Add testcases for DOM4 exception types

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: patch

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 615099 [details] [diff] [review]
patch

Review of attachment 615099 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with that change. Yay!

::: content/base/test/file_bug416317.xhtml
@@ +494,5 @@
>            return root[select](q, resolver);
>          } catch(e){
> +          if ( e.message.indexOf("ERR") > -1 ||
> +              e.name == "NamespaceError" && e.code == DOMException.NAMESPACE_ERR ||
> +              e.name == "SyntaxError" && e.code == DOMException.SYNTAX_ERR)

Please don't rely on the fact that && has higher precedence than || since that's not obvious to everyone. So add some parenthesis here.

@@ +548,5 @@
>              try {
>                results = query(q, resolver);
>              } catch(e) {
> +              pass = (e.message === "bad ERROR" ||
> +                      e.name == "NamespaceError" && e.code == DOMException.NAMESPACE_ERR);

Same here

Comment 3

[Masatoshi Kimura [:emk]]

Attachment: patch for check in

Comment 4

[Ryan VanderMeulen [:RyanVM]]

content/test/unit/test_range.js appears to be bitrotted. Please rebase.

Comment 5

[Masatoshi Kimura [:emk]]

Attachment: patch for check in; r=jonas

Conflicted with bug 702948. Rebased.

Comment 6

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bafdd54189ee

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/bafdd54189ee