The default bug view has changed. See this FAQ.

Update LDAP c-sdk to LDAPCSDK_6_0_7D_RTM

RESOLVED FIXED in Thunderbird 12.0

Status

MailNews Core
Build Config
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Thunderbird 12.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 590663 [details] [diff] [review]
The fix

I've just landed bug 712785 in the LDAP c-sdk. This is a build config change which will stop us rebuilding the LDAP xpcom files everytime through a full build and will mean we shouldn't have to rebuild the XUL library for every rebuild if nothing has changed.

This should save the builders a bit of time, and hopefully some developers as well.

I tagged the LDAP sdks LDAPCSDK_6_0_7C_RTM which allows us to pick it up.
Attachment #590663 - Flags: review?(dbienvenu)

Comment 1

5 years ago
Hi. Does this actually get pulled into libxul? Isn't it in a separate library? When this lands I will test it and look for any other offending files (causing relink).
Thanks for fixing this.
(Assignee)

Comment 2

5 years ago
(In reply to :aceman from comment #1)
> Does this actually get pulled into libxul? Isn't it in a separate
> library?

The LDAP c-sdk (in ldap/sdks/c-sdk) is a separate library, however the ldap-standard.h is included in the LDAP xpcom files (in ldap/xpcom) and those files are pulled into libxul.

> When this lands I will test it and look for any other offending
> files (causing relink).

Bug 714365 is at least one of those.

Comment 3

5 years ago
Thanks.

I think the --disable-ldap option does not work (that is why I must have it enabled and get hit by bug 712785).
Can you look at it or should I file that separately?
(Assignee)

Comment 4

5 years ago
I believe there's already work in progress that will make that work properly.

Comment 5

5 years ago
Yeah, it is Bug 599615. But it looks like the progress on it and its blocker stopped in 2011-08
(Assignee)

Updated

5 years ago
Depends on: 720373
(Assignee)

Comment 6

5 years ago
I'm going to "D" because I want to incorporate bug 720373 as well which just landed.
Summary: Update LDAP c-sdk to LDAPCSDK_6_0_7C_RTM → Update LDAP c-sdk to LDAPCSDK_6_0_7D_RTM
(Assignee)

Comment 7

5 years ago
Created attachment 591072 [details] [diff] [review]
The fix v2
Attachment #590663 - Attachment is obsolete: true
Attachment #590663 - Flags: review?(dbienvenu)
Attachment #591072 - Flags: review?(dbienvenu)

Updated

5 years ago
Attachment #591072 - Flags: review?(dbienvenu) → review+
(Assignee)

Comment 8

5 years ago
Checked in: http://hg.mozilla.org/comm-central/rev/568c0a31db46
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
Blocks: 834214
No longer blocks: 834214
You need to log in before you can comment on or make changes to this bug.