Created attachment 590663 [details] [diff] [review]
I've just landed bug 712785 in the LDAP c-sdk. This is a build config change which will stop us rebuilding the LDAP xpcom files everytime through a full build and will mean we shouldn't have to rebuild the XUL library for every rebuild if nothing has changed.
This should save the builders a bit of time, and hopefully some developers as well.
I tagged the LDAP sdks LDAPCSDK_6_0_7C_RTM which allows us to pick it up.
Hi. Does this actually get pulled into libxul? Isn't it in a separate library? When this lands I will test it and look for any other offending files (causing relink).
Thanks for fixing this.
(In reply to :aceman from comment #1)
> Does this actually get pulled into libxul? Isn't it in a separate
The LDAP c-sdk (in ldap/sdks/c-sdk) is a separate library, however the ldap-standard.h is included in the LDAP xpcom files (in ldap/xpcom) and those files are pulled into libxul.
> When this lands I will test it and look for any other offending
> files (causing relink).
Bug 714365 is at least one of those.
I think the --disable-ldap option does not work (that is why I must have it enabled and get hit by bug 712785).
Can you look at it or should I file that separately?
I believe there's already work in progress that will make that work properly.
Yeah, it is Bug 599615. But it looks like the progress on it and its blocker stopped in 2011-08
I'm going to "D" because I want to incorporate bug 720373 as well which just landed.
Created attachment 591072 [details] [diff] [review]
The fix v2
Checked in: http://hg.mozilla.org/comm-central/rev/568c0a31db46