Closed Bug 720328 Opened 8 years ago Closed 8 years ago

Update LDAP c-sdk to LDAPCSDK_6_0_7D_RTM

Categories

(MailNews Core :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 12.0

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch The fix (obsolete) — Splinter Review
I've just landed bug 712785 in the LDAP c-sdk. This is a build config change which will stop us rebuilding the LDAP xpcom files everytime through a full build and will mean we shouldn't have to rebuild the XUL library for every rebuild if nothing has changed.

This should save the builders a bit of time, and hopefully some developers as well.

I tagged the LDAP sdks LDAPCSDK_6_0_7C_RTM which allows us to pick it up.
Attachment #590663 - Flags: review?(dbienvenu)
Hi. Does this actually get pulled into libxul? Isn't it in a separate library? When this lands I will test it and look for any other offending files (causing relink).
Thanks for fixing this.
(In reply to :aceman from comment #1)
> Does this actually get pulled into libxul? Isn't it in a separate
> library?

The LDAP c-sdk (in ldap/sdks/c-sdk) is a separate library, however the ldap-standard.h is included in the LDAP xpcom files (in ldap/xpcom) and those files are pulled into libxul.

> When this lands I will test it and look for any other offending
> files (causing relink).

Bug 714365 is at least one of those.
Thanks.

I think the --disable-ldap option does not work (that is why I must have it enabled and get hit by bug 712785).
Can you look at it or should I file that separately?
I believe there's already work in progress that will make that work properly.
Yeah, it is Bug 599615. But it looks like the progress on it and its blocker stopped in 2011-08
Depends on: 720373
I'm going to "D" because I want to incorporate bug 720373 as well which just landed.
Summary: Update LDAP c-sdk to LDAPCSDK_6_0_7C_RTM → Update LDAP c-sdk to LDAPCSDK_6_0_7D_RTM
Attached patch The fix v2Splinter Review
Attachment #590663 - Attachment is obsolete: true
Attachment #590663 - Flags: review?(dbienvenu)
Attachment #591072 - Flags: review?(dbienvenu)
Attachment #591072 - Flags: review?(dbienvenu) → review+
Checked in: http://hg.mozilla.org/comm-central/rev/568c0a31db46
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
Blocks: 834214
No longer blocks: 834214
You need to log in before you can comment on or make changes to this bug.