Closed
Bug 720373
Opened 12 years ago
Closed 11 years ago
Use SO_VERSION from environment on OpenBSD to set DLL_SUFFIX
Categories
(Directory :: LDAP C SDK, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gaston, Assigned: gaston)
References
Details
Attachments
(2 files)
958 bytes,
patch
|
richm
:
review+
|
Details | Diff | Splinter Review |
856 bytes,
patch
|
richm
:
review+
|
Details | Diff | Splinter Review |
As was already done in mozilla-central, (see http://mxr.mozilla.org/mozilla-central/source/configure.in#2728 , and bug #648721), we use this patch in OpenBSD's portstree/packages to control the library versionning (see http://www.openbsd.org/cgi-bin/cvsweb/ports/mail/mozilla-thunderbird/patches/patch-ldap_sdks_c-sdk_configure_in?rev=1.1). So let's use the same snippet from mozilla-central, ie use SO_VERSION from the environment if present, and default to 1.0 otherwise.
Assignee | ||
Updated•12 years ago
|
Blocks: openbsdmeta
Assignee | ||
Comment 1•12 years ago
|
||
Assignee: nobody → landry
Attachment #590715 -
Flags: review?(richm)
Updated•12 years ago
|
Attachment #590715 -
Flags: review?(richm) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 2•12 years ago
|
||
Checked in: http://hg.mozilla.org/projects/ldap-sdks/rev/e104d6403813 Bug 720328 will be incorporating this into comm-central.
Blocks: 720328
Status: NEW → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Assignee | ||
Comment 3•12 years ago
|
||
Doh i feel so dumb.. now that the patch ended up in Tb 12, i realized it was doing the wrong thing as "adding an extra ."... i ended up with libprldap60..so.1.0, which is not what was intended. So this patch should finally fix it.
Attachment #619032 -
Flags: review?(richm)
Assignee | ||
Comment 4•12 years ago
|
||
And reopening...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 5•12 years ago
|
||
Rich, can you r+ it ? i'd like to get rid of this patch (http://www.openbsd.org/cgi-bin/cvsweb/ports/mail/mozilla-thunderbird/patches/patch-ldap_sdks_c-sdk_configure_in?rev=1.2;content-type=text%2Fplain) someday..
Assignee | ||
Comment 6•12 years ago
|
||
review ping ?
Updated•11 years ago
|
Attachment #619032 -
Flags: review?(richm) → review+
Assignee | ||
Comment 7•11 years ago
|
||
http://hg.mozilla.org/projects/ldap-sdks/rev/5b05e409d512 http://hg.mozilla.org/projects/ldap-sdks/rev/d213b17fe531 Bug 834214 deals with the incorporation into comm-central
Assignee | ||
Updated•11 years ago
|
Status: REOPENED → RESOLVED
Closed: 12 years ago → 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•11 years ago
|
||
And of course i forgot to regen configure... rs=standard8 over irc. http://hg.mozilla.org/projects/ldap-sdks/rev/76b178a6ba59 http://hg.mozilla.org/projects/ldap-sdks/rev/2b72c62f5450
You need to log in
before you can comment on or make changes to this bug.
Description
•