Closed Bug 720373 Opened 11 years ago Closed 10 years ago
_VERSION from environment on Open BSD to set DLL _SUFFIX
As was already done in mozilla-central, (see http://mxr.mozilla.org/mozilla-central/source/configure.in#2728 , and bug #648721), we use this patch in OpenBSD's portstree/packages to control the library versionning (see http://www.openbsd.org/cgi-bin/cvsweb/ports/mail/mozilla-thunderbird/patches/patch-ldap_sdks_c-sdk_configure_in?rev=1.1). So let's use the same snippet from mozilla-central, ie use SO_VERSION from the environment if present, and default to 1.0 otherwise.
Assignee: nobody → landry
Attachment #590715 - Flags: review?(richm)
Checked in: http://hg.mozilla.org/projects/ldap-sdks/rev/e104d6403813 Bug 720328 will be incorporating this into comm-central.
Doh i feel so dumb.. now that the patch ended up in Tb 12, i realized it was doing the wrong thing as "adding an extra ."... i ended up with libprldap60..so.1.0, which is not what was intended. So this patch should finally fix it.
Attachment #619032 - Flags: review?(richm)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Rich, can you r+ it ? i'd like to get rid of this patch (http://www.openbsd.org/cgi-bin/cvsweb/ports/mail/mozilla-thunderbird/patches/patch-ldap_sdks_c-sdk_configure_in?rev=1.2;content-type=text%2Fplain) someday..
review ping ?
http://hg.mozilla.org/projects/ldap-sdks/rev/5b05e409d512 http://hg.mozilla.org/projects/ldap-sdks/rev/d213b17fe531 Bug 834214 deals with the incorporation into comm-central
Status: REOPENED → RESOLVED
Closed: 11 years ago → 10 years ago
Resolution: --- → FIXED
And of course i forgot to regen configure... rs=standard8 over irc. http://hg.mozilla.org/projects/ldap-sdks/rev/76b178a6ba59 http://hg.mozilla.org/projects/ldap-sdks/rev/2b72c62f5450
You need to log in before you can comment on or make changes to this bug.