Last Comment Bug 720531 - Implement border-image-repeat space keyword
: Implement border-image-repeat space keyword
Status: NEW
[parity-webkit]
: dev-doc-needed
Product: Core
Classification: Components
Component: CSS Parsing and Computation (show other bugs)
: Trunk
: All All
: -- normal with 5 votes (vote)
: ---
Assigned To: Ethan Lin[:ethlin]
:
Mentors:
: 911632 (view as bug list)
Depends on: 548372 713643
Blocks: css3-background css3test
  Show dependency treegraph
 
Reported: 2012-01-23 15:22 PST by Lazar Sumar [:nonsensickle]
Modified: 2016-06-23 03:18 PDT (History)
13 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Part 1. parser changes. (2.03 KB, patch)
2016-06-23 02:43 PDT, Ethan Lin[:ethlin]
ethlin: review? (dbaron)
Details | Diff | Review
Part 2. rendering of border-image-repeat: space (8.86 KB, patch)
2016-06-23 02:48 PDT, Ethan Lin[:ethlin]
ethlin: review? (dbaron)
Details | Diff | Review
Part 3. Add test case for border-image-repeat: space (9.68 KB, patch)
2016-06-23 03:00 PDT, Ethan Lin[:ethlin]
no flags Details | Diff | Review
Part 4. Add 'space' for border in shorthand property test (2.14 KB, patch)
2016-06-23 03:02 PDT, Ethan Lin[:ethlin]
ethlin: review? (dbaron)
Details | Diff | Review
Part 3. Add test case for border-image-repeat: space (15.07 KB, patch)
2016-06-23 03:18 PDT, Ethan Lin[:ethlin]
ethlin: review? (dbaron)
Details | Diff | Review

Description Lazar Sumar [:nonsensickle] 2012-01-23 15:22:57 PST
The current version of the spec, found at 
  http://dev.w3.org/csswg/css3-background/#the-border-image-repeat,
adds the 'space' keyword to the border-image-repeat property.

border-image properties were implemented in bug 497995 which should have landed. The spec is now CR. This bug might/might not be dependent on bug 713643.
Comment 1 Lazar Sumar [:nonsensickle] 2012-01-23 16:13:47 PST
This implementation will be similar to implementation of the background-repeat property in bug 548372.
Comment 2 Lazar Sumar [:nonsensickle] 2012-01-26 11:34:42 PST
Added dependence on bug 548372 because it will implement most of the required functionality so fixing this will be easier after it lands.
Comment 3 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2013-09-01 19:54:22 PDT
*** Bug 911632 has been marked as a duplicate of this bug. ***
Comment 5 percyley 2016-01-12 19:49:51 PST
I updated the MDN document.

https://developer.mozilla.org/en-US/docs/Web/CSS/border-image-repeat
Comment 6 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2016-05-25 11:46:11 PDT
Is this easy following bug 548372?
Comment 7 Ethan Lin[:ethlin] 2016-05-26 00:13:41 PDT
I'll try.
Comment 8 Ethan Lin[:ethlin] 2016-06-23 02:43:04 PDT
Created attachment 8764525 [details] [diff] [review]
Part 1. parser changes.

Add space property to border image.
Comment 9 Ethan Lin[:ethlin] 2016-06-23 02:48:07 PDT
Created attachment 8764528 [details] [diff] [review]
Part 2. rendering of border-image-repeat: space

Handle the rendering of border-image-repeat: space. Basically I reused the rendering of background-repeat, besides the calculation of space. The spec says "The gap before the first tile, the gap after the last tile, and the gaps between tiles are equalized".
Comment 10 Ethan Lin[:ethlin] 2016-06-23 03:00:47 PDT
Created attachment 8764530 [details] [diff] [review]
Part 3. Add test case for border-image-repeat: space

Add test cases for border-image-repeat: space. There are 2 test cases. One is the size of border image larger than div size, the other one is reverse.
Comment 11 Ethan Lin[:ethlin] 2016-06-23 03:02:13 PDT
Created attachment 8764533 [details] [diff] [review]
Part 4. Add 'space' for border in shorthand property test

Add the keyword 'space' for border.
Comment 12 Ethan Lin[:ethlin] 2016-06-23 03:18:27 PDT
Created attachment 8764535 [details] [diff] [review]
Part 3. Add test case for border-image-repeat: space

Add one more test case for the case there are multiple border images on each side.

Note You need to log in before you can comment on or make changes to this bug.