720747 - Completely silence RIL worker by default

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Philipp von Weitershausen [:philikon]]

Lots of debug() calls in ril_worker.js still not guarded by the DEBUG const. We might also want to flip the DEBUG flag to false in RadioInterfaceLayer.js.

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 592262 [details] [diff] [review]
v1

Review of attachment 592262 [details] [diff] [review]:
-----------------------------------------------------------------

Why not wrap the debug call in something higher up (i.e. radioDebug() that has the DEBUG check integrated)? Just seems like it might be a bit cleaner. 

Also, instead of wrapping debug, is there any way we could change the logcat message to prefix with RIL? These messages are completely viable over in the radio logs, as that's what stock android does. The problem is, that's usually a #define in the compilation unit, which we don't exactly have now.

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 592262 [details] [diff] [review]
v1

Review of attachment 592262 [details] [diff] [review]:
-----------------------------------------------------------------

r=me after discussing next steps with philikon. This will work for right now.

Comment 5

[Philipp von Weitershausen [:philikon]]

Summarizing IRL discussion:

* Explicit DEBUG checks prevent us from potentially having to construct expensive log strings.
* We should have more powerful logging in chrome-privileged environments, but it shouldn't block this from landing. Filed bug 723354.

Comment 6

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/mozilla-central/rev/aec5edf48e93