720852 - TP5 pageset has numerous remote network accesses

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[John Schoenick [:johns]]

During usage of the TP5 pageset for the memory tester for our areweslimyet.com graphing/tracking project, I noticed the TP5 pageset causes numerous accesses to remote network resources that were interfering with our test results. We worked around this by restricting firefox to localhost via proxy settings.

Is this a bug, or is the pageset intended to be used in conjunction with network/proxy tweaks if no remote accesses are desired?

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Here are the pages I found that access remote networks:
> http://localhost/page_load_test/tp5/en.wikipedia.org/en.wikipedia.org/wiki/Rorschach_test.html
> http://localhost/page_load_test/tp5/amazon.com/www.amazon.com/Kindle-Wireless-Reader-Wifi-Graphite/dp/B002Y27P3M/507846.html
> http://localhost/page_load_test/tp5/icanhascheezburger.com/icanhascheezburger.com/index.html
> http://localhost/page_load_test/tp5/yandex.ru/yandex.ru/yandsearch@text=mozilla&lr=21215.html
> http://localhost/page_load_test/tp5/163.com/www.163.com/index.html
> http://localhost/page_load_test/tp5/mail.ru/mail.ru/index.html
> http://localhost/page_load_test/tp5/imdb.com/www.imdb.com/title/tt1099212/index.html
> http://localhost/page_load_test/tp5/cnn.com/www.cnn.com/index.html
> http://localhost/page_load_test/tp5/youku.com/www.youku.com/index.html
> http://localhost/page_load_test/tp5/myparentswereawesome.tumblr.com/myparentswereawesome.tumblr.com/index.html
> http://localhost/page_load_test/tp5/hao123.com/hao123.com/index.html
> http://localhost/page_load_test/tp5/rakuten.co.jp/www.rakuten.co.jp/index.html
> http://localhost/page_load_test/tp5/uol.com.br/www.uol.com.br/index.html
> http://localhost/page_load_test/tp5/dailymotion.com/www.dailymotion.com/us.html
> http://localhost/page_load_test/tp5/alipay.com/www.alipay.com/index.html
> http://localhost/page_load_test/tp5/stackoverflow.com/stackoverflow.com/questions/184618/what-is-the-best-comment-in-source-code-you-have-ever-encountered.html
> http://localhost/page_load_test/tp5/taringa.net/www.taringa.net/index.html
> http://localhost/page_load_test/tp5/huffingtonpost.com/www.huffingtonpost.com/index.html
> http://localhost/page_load_test/tp5/digg.com/digg.com/news/story/New_logo_for_Mozilla_Firefox_browser.html
> http://localhost/page_load_test/tp5/filestube.com/www.filestube.com/t/the+vampire+diaries.html
> http://localhost/page_load_test/tp5/dailymail.co.uk/www.dailymail.co.uk/ushome/index.html
> http://localhost/page_load_test/tp5/rambler.ru/www.rambler.ru/index.html
> http://localhost/page_load_test/tp5/xinhuanet.com/xinhuanet.com/index.html
> http://localhost/page_load_test/tp5/56.com/www.56.com/index.html
> http://localhost/page_load_test/tp5/bild.de/www.bild.de/index.html
> http://localhost/page_load_test/tp5/guardian.co.uk/www.guardian.co.uk/index.html
> http://localhost/page_load_test/tp5/naver.com/www.naver.com/index.html
> http://localhost/page_load_test/tp5/noimpactman.typepad.com/noimpactman.typepad.com/index.html
> http://localhost/page_load_test/tp5/mashable.com/mashable.com/index.html
> http://localhost/page_load_test/tp5/xunlei.com/xunlei.com/index.html

Comment 2

[Phil Ringnalda (:philor)]

(In reply to Joel Maher (:jmaher) from comment #1)
> Here are the pages I found that access remote networks:
> http://localhost/page_load_test/tp5/amazon.com/www.amazon.com/Kindle-Wireless-Reader-Wifi-Graphite/dp/B002Y27P3M/507846.html

Perhaps not coincidentally, nearly every time I'm looking at a tp5 log (which I'm doing because it hung, generally) that's what was last loaded. Except for ye olde bug 664371, but alipay must have fixed whatever used to frequently break and break us there.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

hey, we might get these talos tests working much better :)

Comment 4

[Jeff Hammel]

Here is the formula for a HTTP observer:

http://mxr.mozilla.org/mozilla-central/source/browser/devtools/webconsole/HUDService.jsm#2049

Comment 5

[Chris Manchester (limited bugmail, email directly)]

Attachment: log of requests made to a net location other than localhost during tp5 run

I've recorded the requests made during of a few runs of the pageset using the HUD code from comment 4 in an extension . I've attached the results for one of the runs filtered for net locations other than local host. Each request has a line for the url, status, and time.

It looks like attempts to access the network come in two flavors: most of them are 404s that tend to take very little time, and a handful actually resolve and may take longer. I noticed some variability in these numbers between runs, so we may want to do more runs / in a more controlled environment to make sure we find the source of these requests.

Once we agree we've found the source of the requests, we will also need to talk about a strategy for cleaning out the pageset.

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Attachment: log of requests to a location other than localhost as well as error responses

Here is a log of requests outside of localhost as well as error responses that should point us in the direction of remaining issues with the page set.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

this is landed and running on mozilla-central, when bug 764912 lands, it will be the default for m-c/m-i.  I am going to mark this as resolved as it is just a matter of rolling out and letting the train catch up.

Comment 8

[Justin Lebar (not reading bugmail)]

Does this change have any effect on the benchmark results (mean or distribution)?

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

yes, it does.  We have a new test called tp5n vs tp5row which has these new local only files.

Comment 10

[Ed Morley [:emorley]]

As part of bug 1026970, it seems that tp5 is still sadly making external connections:
https://tbpl.mozilla.org/?tree=Try&rev=a06dd6870851&jobname=talos

eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=41946381&full=1&branch=try

02:16:51     INFO -  Non-local network connections are disabled and a connection attempt to ynuf.alipay.com (42.156.180.24) was made.  You should only access hostnames available via the test networking proxy (if running mochitests) or from a test-specific httpd.js server (if running xpcshell tests).  Browser services should be disabled or redirected to a local server.

Comment 11

[Ed Morley [:emorley]]

(In reply to Ed Morley [:edmorley UTC+0] from comment #10)
> As part of bug 1026970, it seems that tp5 is still sadly making external

Continued in bug 1026869 comment 2 (where alipay is being disabled).