Remove element.iQEventData when it's empty

RESOLVED FIXED in Firefox 12

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
5 years ago
a year ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 12

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 591409 [details] [diff] [review]
patch

For bug 658738, I'm investigating if we can treat it as a failure if tests leak global variables, i.e. add new properties on the window object. One of the few remaining unexpected failures is this:

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug580412.js | leaked window property: iQEventData

This is from one of these event listeners:
http://mxr.mozilla.org/mozilla-central/search?string=iQ%28gWindow%29
Attachment #591409 - Flags: review?(ttaubert)
Comment on attachment 591409 [details] [diff] [review]
patch

Review of attachment 591409 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, we totally should clean up after ourselves here.

::: browser/components/tabview/iq.js
@@ +775,2 @@
>            this.unbind(type, elem.iQEventData[type][0].original);
> +      }.bind(this));

Nit: I think it's better to use forEach's second parameter instead of .bind() here.
Attachment #591409 - Flags: review?(ttaubert) → review+
(Assignee)

Updated

5 years ago
Blocks: 720985
(Assignee)

Comment 2

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/6e8de9819b23
Target Milestone: --- → Firefox 12

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/6e8de9819b23
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.