720981 - Remove element.iQEventData when it's empty

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

For bug 658738, I'm investigating if we can treat it as a failure if tests leak global variables, i.e. add new properties on the window object. One of the few remaining unexpected failures is this:

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug580412.js | leaked window property: iQEventData

This is from one of these event listeners:
http://mxr.mozilla.org/mozilla-central/search?string=iQ%28gWindow%29

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 591409 [details] [diff] [review]
patch

Review of attachment 591409 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, we totally should clean up after ourselves here.

::: browser/components/tabview/iq.js
@@ +775,2 @@
>            this.unbind(type, elem.iQEventData[type][0].original);
> +      }.bind(this));

Nit: I think it's better to use forEach's second parameter instead of .bind() here.

Comment 2

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/6e8de9819b23

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6e8de9819b23