721019 - [Page Thumbnails] Add telemetry probes

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

Add telemetry probes that track:

* the time it took to capture a thumbnail
* the time it took to store a thumbnail
* number of cache hits/misses
* ...

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 593459 [details] [diff] [review]
patch v1

Review of attachment 593459 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/thumbnails/PageThumbs.jsm
@@ +76,5 @@
>     * @param aWindow The DOM window to capture a thumbnail from.
>     * @return The newly created canvas containing the image data.
>     */
>    capture: function PageThumbs_capture(aWindow) {
> +    let telemetryCaptureTime = Date.now();

you can just "new Date()" instead, here and elsewhere.

Comment 3

[Dão Gottwald [:dao]]

Please move this to the Firefox section in TelemetryHistograms.h and use the FX prefix. "THUMBNAILS" is too generic.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Will do.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/aa9e6ef78d06

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/aa9e6ef78d06