Note: There are a few cases of duplicates in user autocompletion which are being worked on.

[Page Thumbnails] Add telemetry probes

RESOLVED FIXED in Firefox 13

Status

()

Firefox
Tabbed Browser
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Add telemetry probes that track:

* the time it took to capture a thumbnail
* the time it took to store a thumbnail
* number of cache hits/misses
* ...
(Assignee)

Updated

6 years ago
Blocks: 671038
(Assignee)

Comment 1

6 years ago
Created attachment 593459 [details] [diff] [review]
patch v1
Assignee: nobody → ttaubert
Attachment #593459 - Flags: review?(dietrich)
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
Comment on attachment 593459 [details] [diff] [review]
patch v1

Review of attachment 593459 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/thumbnails/PageThumbs.jsm
@@ +76,5 @@
>     * @param aWindow The DOM window to capture a thumbnail from.
>     * @return The newly created canvas containing the image data.
>     */
>    capture: function PageThumbs_capture(aWindow) {
> +    let telemetryCaptureTime = Date.now();

you can just "new Date()" instead, here and elsewhere.
Attachment #593459 - Flags: review?(dietrich) → review+
Please move this to the Firefox section in TelemetryHistograms.h and use the FX prefix. "THUMBNAILS" is too generic.
(Assignee)

Comment 4

6 years ago
Will do.
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/integration/fx-team/rev/aa9e6ef78d06
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 13
(Assignee)

Comment 6

6 years ago
https://hg.mozilla.org/mozilla-central/rev/aa9e6ef78d06
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
You need to log in before you can comment on or make changes to this bug.