Closed
Bug 721019
Opened 13 years ago
Closed 13 years ago
[Page Thumbnails] Add telemetry probes
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 13
People
(Reporter: ttaubert, Assigned: ttaubert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
4.61 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
Add telemetry probes that track:
* the time it took to capture a thumbnail
* the time it took to store a thumbnail
* number of cache hits/misses
* ...
Assignee | ||
Comment 1•13 years ago
|
||
Assignee: nobody → ttaubert
Attachment #593459 -
Flags: review?(dietrich)
Assignee | ||
Updated•13 years ago
|
Status: NEW → ASSIGNED
Comment 2•13 years ago
|
||
Comment on attachment 593459 [details] [diff] [review]
patch v1
Review of attachment 593459 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/components/thumbnails/PageThumbs.jsm
@@ +76,5 @@
> * @param aWindow The DOM window to capture a thumbnail from.
> * @return The newly created canvas containing the image data.
> */
> capture: function PageThumbs_capture(aWindow) {
> + let telemetryCaptureTime = Date.now();
you can just "new Date()" instead, here and elsewhere.
Attachment #593459 -
Flags: review?(dietrich) → review+
Comment 3•13 years ago
|
||
Please move this to the Firefox section in TelemetryHistograms.h and use the FX prefix. "THUMBNAILS" is too generic.
Assignee | ||
Comment 4•13 years ago
|
||
Will do.
Assignee | ||
Comment 5•13 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 13
Assignee | ||
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
You need to log in
before you can comment on or make changes to this bug.
Description
•