Last Comment Bug 721019 - [Page Thumbnails] Add telemetry probes
: [Page Thumbnails] Add telemetry probes
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Tabbed Browser (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 13
Assigned To: Tim Taubert [:ttaubert]
:
:
Mentors:
Depends on:
Blocks: 671038
  Show dependency treegraph
 
Reported: 2012-01-25 07:21 PST by Tim Taubert [:ttaubert]
Modified: 2012-02-04 02:36 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch v1 (4.61 KB, patch)
2012-02-01 08:23 PST, Tim Taubert [:ttaubert]
dietrich: review+
Details | Diff | Splinter Review

Description Tim Taubert [:ttaubert] 2012-01-25 07:21:36 PST
Add telemetry probes that track:

* the time it took to capture a thumbnail
* the time it took to store a thumbnail
* number of cache hits/misses
* ...
Comment 1 Tim Taubert [:ttaubert] 2012-02-01 08:23:33 PST
Created attachment 593459 [details] [diff] [review]
patch v1
Comment 2 Dietrich Ayala (:dietrich) 2012-02-02 02:52:27 PST
Comment on attachment 593459 [details] [diff] [review]
patch v1

Review of attachment 593459 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/thumbnails/PageThumbs.jsm
@@ +76,5 @@
>     * @param aWindow The DOM window to capture a thumbnail from.
>     * @return The newly created canvas containing the image data.
>     */
>    capture: function PageThumbs_capture(aWindow) {
> +    let telemetryCaptureTime = Date.now();

you can just "new Date()" instead, here and elsewhere.
Comment 3 Dão Gottwald [:dao] 2012-02-02 03:05:46 PST
Please move this to the Firefox section in TelemetryHistograms.h and use the FX prefix. "THUMBNAILS" is too generic.
Comment 4 Tim Taubert [:ttaubert] 2012-02-02 03:07:15 PST
Will do.
Comment 5 Tim Taubert [:ttaubert] 2012-02-02 07:23:26 PST
https://hg.mozilla.org/integration/fx-team/rev/aa9e6ef78d06
Comment 6 Tim Taubert [:ttaubert] 2012-02-04 02:36:49 PST
https://hg.mozilla.org/mozilla-central/rev/aa9e6ef78d06

Note You need to log in before you can comment on or make changes to this bug.