721216 - Bitmap compression on main thread causes the tab strip to take a long time to appear

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Patrick Walton (:pcwalton)]

It can take a few seconds for the tabs to appear when the tab strip button is tapped. This is due to this call stack:

* Bitmap.nativeCompress
* Bitmap.compress
* GeckoApp.getAndProcessThumbnailForTab
* Tabs.refreshThumbnails
* TabsTray.onCreate

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 2

[Patrick Walton (:pcwalton)]

This helps significantly. It still takes too long to open the tab strip (about a second), and switching tabs takes a long time as well, but those are separate bugs.

Comment 3

[Patrick Walton (:pcwalton)]

Comment on attachment 591638 [details] [diff] [review]
patch

Review of attachment 591638 [details] [diff] [review]:
-----------------------------------------------------------------

r=me.

But can we put image decoding in a background thread so that it doesn't block the UI at all?

::: mobile/android/base/Tabs.java
@@ +221,5 @@
> +        GeckoAppShell.getHandler().post(new Runnable() {
> +            public void run() {
> +                Iterator<Tab> iterator = tabs.values().iterator();
> +                while (iterator.hasNext())
> +                    GeckoApp.mAppContext.getAndProcessThumbnailForTab(iterator.next());

nit: {}

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7f26e362a9f7

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7f26e362a9f7

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 591638 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Tab menu opens slowly
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
This patch depends on bug 721308 since it is possible to cause a crash with it alone. With both patches this is pretty safe.

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 591638 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.

Comment 9

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/75bb8908cef0