721523 - Flash of unstyled content in Fennec nightly as AMO loads

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://addons-dev.allizom.org/en-US/android in Fennec nightly on your android phone.


actual behavior:
Flash of unstyled content in Fennec nightly as AMO loads

Comment 1

[Wil Clouser [:clouserw]]

This happens because of the speed of the device and of the internet connection.  It would happen on your desktop too if it were less powerful.  Did you have something specific in mind for this bug?  Otherwise it's a wontfix.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

I suspect this to be a Nightly bug. I could reproduce on my Galaxy tablet using Nightly. It works fine in stable versions of Firefox (tested with 8.0).

I believe this is due to our putting our <script> tags at the bottom of the page, but I'm going to try to find more reliable STR.

Let's not WONTFIX until we're certain what's causing this.

Comment 3

[Martijn Wargers (dead)]

Attachment: stylesheet needed for testcase

Comment 4

[Martijn Wargers (dead)]

Attachment: testcase

Comment 5

[Martijn Wargers (dead)]

Attachment: testcase2, without meta viewport tag

When the meta viewport tag is removed:
    <meta name="viewport" content="width=device-width, user-scalable=no, maximum-scale=1">
Then the bug doesn't occur, so I guess you could call this a Fennec bug.

Comment 6

[Martijn Wargers (dead)]

Perhaps there can be done something from Fennec's side here, but I think this can also be worked around by amo.

Comment 8

[Martijn Wargers (dead)]

Duped bug 755865 had blocking-fennec1.0+ set, so this one should too.

Comment 9

[Christopher Van Wiemeersch [:cvan]]

I'll take a look

Comment 10

[Christopher Van Wiemeersch [:cvan]]

(In reply to Martijn Wargers [:mw22] (QA - IRC nick: mw22) from comment #6)
> Perhaps there can be done something from Fennec's side here, but I think
> this can also be worked around by amo.

Can we file a bug against Fennec? Both test cases fail for me on my Galaxy Tablet  running May 29's Nightly.

Comment 11

[Martijn Wargers (dead)]

Ok, I filed bug 759678.

Comment 12

[Wil Clouser [:clouserw]]

(In reply to Martijn Wargers [:mw22] (QA - IRC nick: mw22) from comment #11)
> Ok, I filed bug 759678.

Thanks.  There is nothing we can do here so I'm closing this bug in favor of the platform bug.

Comment 13

[Martijn Wargers (dead)]

What do you mean, there's nothing you can do here? I think it would be possible to circumvent this bug from occuring in Fennec.

But I guess that since this bug is marked blocking-Fennec1.0+, it will be fixed before release.

Comment 14

[Christopher Van Wiemeersch [:cvan]]

(In reply to Martijn Wargers [:mw22] (QA - IRC nick: mw22) from comment #13)
> What do you mean, there's nothing you can do here? I think it would be
> possible to circumvent this bug from occuring in Fennec.
> 
> But I guess that since this bug is marked blocking-Fennec1.0+, it will be
> fixed before release.

From my testing, removing the <meta> tag does not affect the flickering in Fennec. It was a Fennec regression, and we should try to get it fixed properly.

Comment 15

[Martijn Wargers (dead)]

Adding a <script src=""></script> after the <link> seems to fix the issue.
Learned this from: http://molily.de/weblog/domcontentloaded

You can see it in action here: http://people.mozilla.org/~mwargers/tests/unminimized/Add-ons%20for%20Android.htm

Comment 16

[Martijn Wargers (dead)]

Also tested it here: http://people.mozilla.org/~mwargers/tests/layout/bugs/

Comment 17

[Christopher Van Wiemeersch [:cvan]]

(In reply to Martijn Wargers [:mw22] (QA - IRC nick: mw22) from comment #15)
> Adding a <script src=""></script> after the <link> seems to fix the issue.
> Learned this from: http://molily.de/weblog/domcontentloaded
> 
> You can see it in action here:
> http://people.mozilla.org/~mwargers/tests/unminimized/Add-
> ons%20for%20Android.htm

https://github.com/mozilla/zamboni/commit/39fafe2

Added workaround until Fennec fixes this properly (bug 759678). This is visible in staging/dev until it lands in production next week (Thurs, June 7):

    https://addons-dev.allizom.org/

Thanks for investigating the bug and following up.

Comment 18

[Potch [:potch]]

(In reply to Martijn Wargers [:mw22] (QA - IRC nick: mw22) from comment #15)
> Adding a <script src=""></script> after the <link> seems to fix the issue.
> Learned this from: http://molily.de/weblog/domcontentloaded
> 
> You can see it in action here:
> http://people.mozilla.org/~mwargers/tests/unminimized/Add-
> ons%20for%20Android.htm

This causes a syntax error on every page, so we can't do this.

Comment 19

[Potch [:potch]]

https://github.com/mozilla/zamboni/commit/2fbdeea

Comment 20

[Boris Zbarsky [:bzbarsky]]

Just use:

  <script></script>

instead.  It should have the side benefit of not needing an HTTP request...

Comment 21

[Kartikaya Gupta (email:[e-mail])]

Just a FYI, I have a patch that fixes this properly in Fennec, pending review on bug 759678.

Comment 22

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Kartikaya Gupta (:kats) from comment #21)
> Just a FYI, I have a patch that fixes this properly in Fennec, pending
> review on bug 759678.

we're not taking that fix for 14 because of the risk involved. We still need a work around fix to land in AMO.

Comment 23

[Christopher Van Wiemeersch [:cvan]]

(In reply to Brad Lassey [:blassey] from comment #22)
> (In reply to Kartikaya Gupta (:kats) from comment #21)
> > Just a FYI, I have a patch that fixes this properly in Fennec, pending
> > review on bug 759678.
> 
> we're not taking that fix for 14 because of the risk involved. We still need
> a work around fix to land in AMO.

The <script> workaround did not appear to fix the flicker. Krupa, can you confirm this?

Comment 24

[Potch [:potch]]

This solves the problem quite succinctly. We'll need to revert *as soon* as bug 759678 lands.

https://github.com/mozilla/zamboni/commit/7aad297

Comment 25

[Potch [:potch]]

Fixing image references. May god have mercy on my soul :)

https://github.com/mozilla/zamboni/commit/ff75782