Source Editor needs to use the minimal requirejs implementation

RESOLVED WONTFIX

Status

P3
normal
RESOLVED WONTFIX
7 years ago
2 months ago

People

(Reporter: msucan, Assigned: msucan)

Tracking

Trunk
Future

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [sourceeditor][orion][yo-dawg])

(Assignee)

Description

7 years ago
Orion codebase uses requirejs and they currently have a minimal shim for define() and require(), but this is going to be removed. We need to update the Source Editor code to use our requirejs shim. Also, we should extract it from gcli.jsm and put into its own browser/devtools/shared/requirejs.jsm or something.
(Assignee)

Updated

7 years ago
Whiteboard: [sourceeditor][orion]
I hear you like modules...
Whiteboard: [sourceeditor][orion] → [sourceeditor][orion][yo-dawg]
Currently our require shim lives in dryice, which makes a ton of sense from a dryice point of view - it's building script files that depend on it.

However from a mozilla pov, it makes no sense to have many copies of the same thing, so there is work to do. 

However the pain felt is duplication of a few ks of script. i.e. low.
Also, does the orion integration still need this?

P.S. Sup dawg.
Priority: -- → P4
(Assignee)

Comment 3

7 years ago
(In reply to Joe Walker from comment #2)
> Currently our require shim lives in dryice, which makes a ton of sense from
> a dryice point of view - it's building script files that depend on it.
> 
> However from a mozilla pov, it makes no sense to have many copies of the
> same thing, so there is work to do. 
> 
> However the pain felt is duplication of a few ks of script. i.e. low.
> Also, does the orion integration still need this?

This is a recent change in Orion. They still have the requirejs shim in their codebase, but as soon as they remove it, this bug is going to become pretty much P1 for any further Orion updates.

P4 works, as long as they don't remove the requirejs shim. ;)

In terms of duplication: the approach we use to fix this bug can vary. We can either move the code you have outside into a reusable jsm, or we can duplicate it in SourceEditor, or whatever we think it's best at that point.
(In reply to Mihai Sucan [:msucan] from comment #3)
> This is a recent change in Orion. They still have the requirejs shim in
> their codebase, but as soon as they remove it, this bug is going to become
> pretty much P1 for any further Orion updates.
> 
> P4 works, as long as they don't remove the requirejs shim. ;)
> 
> In terms of duplication: the approach we use to fix this bug can vary. We
> can either move the code you have outside into a reusable jsm, or we can
> duplicate it in SourceEditor, or whatever we think it's best at that point.

Thanks - that background helps.
The good news is that I think this should be quite simple (assuming their current shim is similar to ours)
GCLI Triage.
Target Milestone: --- → Firefox 15
This bug is fixed by bug 742672. I'll probably mark this as a duplicate when that lands.
(Assignee)

Comment 7

6 years ago
(In reply to Joe Walker from comment #6)
> This bug is fixed by bug 742672. I'll probably mark this as a duplicate when
> that lands.

Great!

Please keep this bug open. We still need to update the Source Editor as well, to use the new require.jsm.

Thank you!
(In reply to Mihai Sucan [:msucan] from comment #7)
> (In reply to Joe Walker from comment #6)
> > This bug is fixed by bug 742672. I'll probably mark this as a duplicate when
> > that lands.
> 
> Great!
> 
> Please keep this bug open. We still need to update the Source Editor as
> well, to use the new require.jsm.

OK, in which case it doesn't block bug 745773.
No longer blocks: 745773
Summary: Source Editor needs to use the minimal requirejs implementation from Gcli → Source Editor needs to use the minimal requirejs implementation
Target Milestone: Firefox 15 → Future
(Assignee)

Comment 9

6 years ago
This is going to be fixed by bug 759351.
Assignee: nobody → mihai.sucan
Status: NEW → ASSIGNED
Depends on: 759351
Priority: P4 → P3
Moving to Source Editor component.

Filter on CHELICERAE.
Component: Developer Tools → Developer Tools: Source Editor
Is this still an issue with SourceEditor in general or CodeMirror specifically?
Flags: needinfo?(mihai.sucan)
(Assignee)

Comment 12

5 years ago
(In reply to Anton Kovalyov (:anton) from comment #11)
> Is this still an issue with SourceEditor in general or CodeMirror
> specifically?

This bug is no longer applicable. We had Orion integrated with its own requirejs shim. This bug was about switching from their requirejs shim to ours.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: needinfo?(mihai.sucan)
Resolution: --- → WONTFIX

Updated

2 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.