721920 - Honor the 'lang' attribute on SVG as we do in HTML

Status: RESOLVED FIXED

Description

[Jonathan Watt [:jwatt]]

We should support the 'lang' attribute in SVG just as we do in HTML.

Comment 1

[Jonathan Watt [:jwatt]]

Created attachment 592325 [details]
testcase

Comment 2

[Jonathan Watt [:jwatt]]

Chrome supports this.

Comment 3

[Cameron McCormack (:heycam)]

SVG 1.1 uses xml:lang="" for declaring the language of text content, and lang="" just for declaring what language a particular SVG Font glyph is for.  I'll file an issue for SVG 2 to use lang="" rather than xml:lang="".

Comment 4

[Jonathan Watt [:jwatt]]

Thanks, that'd be great.

Comment 5

[Jonathan Watt [:jwatt]]

Created attachment 592432 [details]
testcase showing lang="foo" working in HTML

Comment 6

[Jonathan Watt [:jwatt]]

Created attachment 592484 [details] [diff] [review]
patch

Still need tests, but this works. (The fact that selector matching doesn't use the nsStyleFont struct caught me out for a while, but I figured it out.)

Comment 7

[Jonathan Watt [:jwatt]]

> The fact that selector matching doesn't use the nsStyleFont struct...

By which I mean the code for ePseudoClass_lang in nsCSSRuleProcessor.cpp uses GetLang(), not an nsStyleFont...hence the change to nsIContent.h in the patch.

Comment 8

[Jonathan Watt [:jwatt]]

Created attachment 592486 [details] [diff] [review]
patch

Comment 9

[Jonathan Watt [:jwatt]]

Created attachment 598198 [details] [diff] [review]
patch

Comment 10

[Boris Zbarsky [:bz] (if a patch has no decent message, automatic r-)]

Comment on attachment 598198 [details] [diff] [review]
patch

r=me

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d9c03190bd47