Closed
Bug 721920
Opened 10 years ago
Closed 10 years ago
Honor the 'lang' attribute on SVG as we do in HTML
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: jwatt, Assigned: jwatt)
References
(Blocks 1 open bug, )
Details
(Keywords: dev-doc-needed)
Attachments
(3 files, 2 obsolete files)
We should support the 'lang' attribute in SVG just as we do in HTML.
![]() |
Assignee | |
Comment 1•10 years ago
|
||
![]() |
Assignee | |
Updated•10 years ago
|
Attachment #592325 -
Attachment is patch: false
![]() |
Assignee | |
Updated•10 years ago
|
Attachment #592325 -
Attachment mime type: text/plain → image/svg+xml
![]() |
Assignee | |
Comment 2•10 years ago
|
||
Chrome supports this.
Comment 3•10 years ago
|
||
SVG 1.1 uses xml:lang="" for declaring the language of text content, and lang="" just for declaring what language a particular SVG Font glyph is for. I'll file an issue for SVG 2 to use lang="" rather than xml:lang="".
![]() |
Assignee | |
Comment 4•10 years ago
|
||
Thanks, that'd be great.
![]() |
Assignee | |
Comment 5•10 years ago
|
||
![]() |
Assignee | |
Comment 6•10 years ago
|
||
Still need tests, but this works. (The fact that selector matching doesn't use the nsStyleFont struct caught me out for a while, but I figured it out.)
![]() |
Assignee | |
Comment 7•10 years ago
|
||
> The fact that selector matching doesn't use the nsStyleFont struct...
By which I mean the code for ePseudoClass_lang in nsCSSRuleProcessor.cpp uses GetLang(), not an nsStyleFont...hence the change to nsIContent.h in the patch.
![]() |
Assignee | |
Comment 8•10 years ago
|
||
Attachment #592484 -
Attachment is obsolete: true
![]() |
Assignee | |
Comment 9•10 years ago
|
||
Attachment #592486 -
Attachment is obsolete: true
Attachment #598198 -
Flags: review?(bzbarsky)
![]() |
||
Comment 10•10 years ago
|
||
Comment on attachment 598198 [details] [diff] [review] patch r=me
Attachment #598198 -
Flags: review?(bzbarsky) → review+
Comment 11•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d9c03190bd47
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
Updated•6 years ago
|
Keywords: dev-doc-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•