728974 - ABORT: Only 'lang' should be unrecognized!: 'aMappedAttrName == nsGkAtoms::lang'

Status: RESOLVED WORKSFORME

(Core :: SVG, defect)

Description

[Jesse Ruderman]

Attachment: testcase (asserts fatally when loaded)

###!!! ABORT: Only 'lang' should be unrecognized!: 'aMappedAttrName == nsGkAtoms::lang', file content/svg/content/src/nsSVGElement.cpp, line 1174

This assertion is part of code added in bug 721920.

Comment 1

[Jonathan Watt [:jwatt]]

Hmm, interesting. I assumed that nsCSSProps::LookupProperty would return something for all properties that IsMappedAttribute returns true for except the new hack to map 'lang'. I guess we can just remove that abort, but maybe we can/should replace it with some sort of less strict check? Any opinion, Boris?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Yep, looks like we claim some things are mapped that we never actually map anywhere...  Assuming that's expected, I really don't see what sort of less strict check you could do here.

Comment 3

[Bob Clary [:bc] (inactive)]

reproduces with http://www.six-swiss-exchange.com/funds/security_info_de.html?id=CH0014420852CHF4

all branches, all platforms.

Comment 4

[Bob Clary [:bc] (inactive)]

also http://www.denverpost.com/news/ci_20839469/colorado-high-park-fire-social-media-map

Comment 5

[Carsten Book [:Tomcat]]

does not crash anymore -> wfm

Comment 6

[Jesse Schwartzentruber (:truber)]

Attachment: new testcase (asserts with pref layout.css.vertical-text.enabled=false)

New testcase attached, needs 'user_pref("layout.css.vertical-text.enabled", false);' to repro.

Comment 7

[Andrei Purice]

Following the reporter's steps I am able to confirm that the issues doesn't happen anymore on Windows 10 and MacOs 10.15 on any of the current versions of Firefox Nightly 87.0a1 (2021-02-16), beta 86.0 and release 85.0.2. The example test cases or the given site (with the pref set to false as well) don't crash Firefox anymore.

Closing this issue as Resolved > Worksforme.
Feel free to re-open or file a new bug if this issue reoccurs again.