722125 - NSPR always builds as armv5te on Android

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P1)

Description

[Makoto Kato [:m_kato]]

This bug is separated from bug 693329.

CPU_ARCH isn't set on "ARM toolchain tweaks", MOZ_THUMB, MOZ_ARCH, MOZ_FPU and MOZ_FLOAT_ABI aren't set on Android build.  So android toolchain uses default option (armv5te).

Comment 1

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 2

[Makoto Kato [:m_kato]]

This seems to be a regression by bug 674880.

Comment 3

[Mike Hommey [:glandium]]

CPU_ARCH and OS_TARGET are actually set in configure.in... but after the arm-Android test from bug 674880 :(

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 592470 [details] [diff] [review]
fix

Review of attachment 592470 [details] [diff] [review]:
-----------------------------------------------------------------

It seems a bit silly to add this much code just to support this one case statement. Can't we simply change the ARM toolchain tweaks line to:
case "${target_cpu}-${OS_TARGET}" in

?

Comment 5

[Mike Hommey [:glandium]]

(In reply to Ted Mielczarek [:ted, :luser] from comment #4)
> Comment on attachment 592470 [details] [diff] [review]
> fix
> 
> Review of attachment 592470 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> It seems a bit silly to add this much code just to support this one case
> statement. Can't we simply change the ARM toolchain tweaks line to:
> case "${target_cpu}-${OS_TARGET}" in
> 
> ?

See comment 3. OS_TARGET is set after that. It would need to be a case "$target", with the right wildcard.

Comment 6

[Makoto Kato [:m_kato]]

Attachment: fix v2

Comment 7

[(not currently active) Ted Mielczarek]

Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.322; previous revision: 1.321
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.324; previous revision: 1.323
done

Comment 8

[Wan-Teh Chang]

Ted: it's the target milestone that is 4.9.1 :-)

Thank you for reviewing and checking this in.