Closed Bug 722125 Opened 8 years ago Closed 8 years ago

NSPR always builds as armv5te on Android

Categories

(NSPR :: NSPR, defect, P1)

4.8.9
ARM
Android
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file, 1 obsolete file)

This bug is separated from bug 693329.

CPU_ARCH isn't set on "ARM toolchain tweaks", MOZ_THUMB, MOZ_ARCH, MOZ_FPU and MOZ_FLOAT_ABI aren't set on Android build.  So android toolchain uses default option (armv5te).
Attached patch fix (obsolete) — Splinter Review
Attachment #592470 - Flags: review?(ted.mielczarek)
This seems to be a regression by bug 674880.
Blocks: 693329
CPU_ARCH and OS_TARGET are actually set in configure.in... but after the arm-Android test from bug 674880 :(
Comment on attachment 592470 [details] [diff] [review]
fix

Review of attachment 592470 [details] [diff] [review]:
-----------------------------------------------------------------

It seems a bit silly to add this much code just to support this one case statement. Can't we simply change the ARM toolchain tweaks line to:
case "${target_cpu}-${OS_TARGET}" in

?
Attachment #592470 - Flags: review?(ted.mielczarek) → review-
(In reply to Ted Mielczarek [:ted, :luser] from comment #4)
> Comment on attachment 592470 [details] [diff] [review]
> fix
> 
> Review of attachment 592470 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> It seems a bit silly to add this much code just to support this one case
> statement. Can't we simply change the ARM toolchain tweaks line to:
> case "${target_cpu}-${OS_TARGET}" in
> 
> ?

See comment 3. OS_TARGET is set after that. It would need to be a case "$target", with the right wildcard.
Attached patch fix v2Splinter Review
Attachment #592470 - Attachment is obsolete: true
Attachment #597318 - Flags: review?(ted.mielczarek)
Attachment #597318 - Flags: review?(ted.mielczarek) → review+
Assignee: wtc → m_kato
Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.322; previous revision: 1.321
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.324; previous revision: 1.323
done
Status: NEW → RESOLVED
Closed: 8 years ago
OS: Linux → Android
Hardware: x86_64 → ARM
Resolution: --- → FIXED
Version: other → 4.9.1
Ted: it's the target milestone that is 4.9.1 :-)

Thank you for reviewing and checking this in.
Target Milestone: --- → 4.9.1
Version: 4.9.1 → other
Priority: -- → P1
Version: other → 4.8.9
No longer blocks: 693329
You need to log in before you can comment on or make changes to this bug.