Change layout/reftests/bidi/718236-1.html to avoid subpixel failures on win7 unaccelerated (and 718236-2.html, 718236-3.html)

RESOLVED FIXED in Firefox 12

Status

()

Core
Layout: Text
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla13
x86
Windows 7
Points:
---

Firefox Tracking Flags

(firefox12 fixed)

Details

(Whiteboard: [qa-])

Attachments

(4 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 592561 [details] [diff] [review]
patch

I've been having some Try problems with the layout/reftests/bidi/718236-x.html reftests running on the Windows 7 machine without hardware acceleration. Basically imperceptible subpixel differences. Simon suggested changing the references for the tests in the way I've changed them in the patch, and indeed that fixes the problem.
Attachment #592561 - Flags: review?(smontagu)
Comment on attachment 592561 [details] [diff] [review]
patch

Review of attachment 592561 [details] [diff] [review]:
-----------------------------------------------------------------

For the record, I suggested this fix to Jonathan based on bug 696672 comment 3: "in the reference we render all of the text in one call which causes the blending of the overlap between the ':' and the 'M' to be different than if we render the strings in two steps".

Looking at that again, I wonder if increasing the letter-spacing would be a more elegant fix for this and also bug 69667[123], but that can be a follow-up bug so as not to hold up bug 416581
Attachment #592561 - Flags: review?(smontagu) → review+
(Assignee)

Comment 2

5 years ago
Created attachment 592653 [details] [diff] [review]
patch with style="letter-spacing: 3px;"

This hasn't passed Try yet, but assuming it does, does this look okay?

https://tbpl.mozilla.org/?tree=Try&rev=875a31fd0056
Attachment #592653 - Flags: review?(smontagu)
(Assignee)

Updated

5 years ago
Attachment #592653 - Attachment is patch: true
(Assignee)

Updated

5 years ago
Assignee: nobody → jwatt
(Assignee)

Comment 3

5 years ago
(In reply to Simon Montagu from comment #1)
> but that can be a follow-up bug so as not to hold up bug 416581

Certainly appreciated, but dbaron is really busy right now, so I think there's likely plenty of time before he gets to reviewing that patch. :)
(Assignee)

Comment 4

5 years ago
Created attachment 592704 [details]
reftest log of failure with letter-spacing

Hmm, letter-spacing did not fix the problem in this case. It seems that it's just something to do with the painting of the top left of the Hebrew glyph "٣". Maybe we should just change that letter to something that doesn't cause problems?
(Assignee)

Updated

5 years ago
Attachment #592653 - Attachment is obsolete: true
Attachment #592653 - Flags: review?(smontagu)
(Assignee)

Comment 5

5 years ago
For what it's worth, I'm noticing that these three tests are failing for people quite often on Try on that Windows 7 box when run without hardware acceleration. Strange it doesn't seem to be happening on m-c tbpl.
(In reply to Jonathan Watt [:jwatt] from comment #4)
> Hmm, letter-spacing did not fix the problem in this case. It seems that it's
> just something to do with the painting of the top left of the Hebrew glyph
> "٣". Maybe we should just change that letter to something that doesn't cause
> problems?

For the purposes of what the test is testing, there just needs to be two different characters in the range ٠ to ٩ (or anything with the bidi property AN, but those are the most familiar). JFTR, these are Arabic digits, not Hebrew.
Blocks: 722617
Could the new fuzzy-if help here?
If I'm understanding the documentation of fuzzy-if correctly (and I'm not sure that I am), it won't help. In the results in comment 4, there are two pixels with different values, one with 0xffffff/0xffffb6 and one with 0xffffff/0xffffdb
(Assignee)

Updated

5 years ago
Summary: Change layout/reftests/bidi/718236-x.html to avoid subpixel failures on win7 unaccelerated → Change layout/reftests/bidi/718236-1.html to avoid subpixel failures on win7 unaccelerated (and 718236-2.html, 718236-3.html)
(Assignee)

Comment 9

5 years ago
Created attachment 593081 [details] [diff] [review]
patch - change problem character

I pushed another changeset to Try, this time changing the character that's causing the problem to something else:

https://tbpl.mozilla.org/?tree=Try&rev=32dd21a768a4

(The changeset isn't showing up there because it was actually from the previous push which I cancelled.)

Requesting review, assuming that passes Try.
Attachment #593081 - Flags: review?
(Assignee)

Updated

5 years ago
Attachment #593081 - Flags: review? → review?(smontagu)
(Assignee)

Updated

5 years ago
Attachment #593081 - Flags: review?(smontagu)
(Assignee)

Comment 10

5 years ago
Created attachment 593161 [details]
failure lines from reftest log with character changed
(Assignee)

Comment 11

5 years ago
I pushed the original (if less than ideal) patch to m-i:

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=7cef99596d92
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/7cef99596d92
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Comment on attachment 592561 [details] [diff] [review]
patch

[Approval Request Comment]
Test-only change, needed on aurora and beta so that we can start running Windows unaccelerated reftests somewhere other than just on tryserver, like we started to do in November 2010.
Attachment #592561 - Flags: approval-mozilla-beta?
Attachment #592561 - Flags: approval-mozilla-aurora?
Comment on attachment 592561 [details] [diff] [review]
patch

Wups, only needed on aurora, since those tests aren't on beta.
Attachment #592561 - Flags: approval-mozilla-beta?
Comment on attachment 592561 [details] [diff] [review]
patch

[Triage Comment]
Changes to reftests and low risk - approved for Aurora 12.
Attachment #592561 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/77b10632390c
status-firefox12: --- → fixed
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.