722265 - Column header selection popup no longer exposed to accessibility APIs

Status: RESOLVED FIXED

(Thunderbird :: Disability Access, defect)

Description

[James Teh [:Jamie]]

The popup used to select columns to display is no longer exposed to accessibility APIs. Although the button to access the popup can't be focused or activated from the keyboard (bug 370437), it was previously possible to find and activate the accessible for this button, thereby displaying the popup. The popup was then accessible via the keyboard and exposed information to accessibility APIs, thus allowing a screen reader user to toggle column visibility. Now, even after the button is activated, the popup does not expose any accessibles at all.

Str:
1. Click the button labelled "Click to select columns to display" in the message list column headers.
2. Press downArrow.
Expected: The selected column item should receive focus according to accessibility APIs.
Actual: Nothing is communicated via accessibility APIs.

This worked in Thudnerbird 3.1.18. It does not work in trunk. I'm not yet sure where it broke after 3.1.18.

I'm not sure whether this is a core -> disability access APIs bug, so I've put it here initially.

Comment 1

[Marco Zehe (:MarcoZ)]

This sounds to me like another case of the problem in bug 673860.

Comment 2

[James Teh [:Jamie]]

Unfortunately, this is not fixed by bug 656225, which suggests it's not another instance of bug 673860.

Comment 3

[alexander :surkov (:asurkov)]

Can anybody extract guilty XUL for me please?

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Could this be put into the View menu options?

Comment 5

[alexander :surkov (:asurkov)]

(In reply to Liz Henry :lizzard from comment #4)
> Could this be put into the View menu options?

this would do a job for particular app but we'd need to fix it in general way

Comment 6

[alexander :surkov (:asurkov)]

XUL button doesn't allow any children if this not a menu button. XUL tree uses xul:treecolumnpicker which is not recognized as a menu button. Similar to bug 787858 and MustPrune problem. While this one can have a trivial fix (treat treecolumnpicker as a menu button) but we deal here with a more general problem.

Comment 7

[alexander :surkov (:asurkov)]

Attachment: patch

allow menupopup under any XUL button

Comment 8

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b27220008ea6

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b27220008ea6