Closed Bug 722514 Opened 13 years ago Closed 13 years ago

AndroidBrowserRepositorySession.java reconcileRecords incorrect guid string comparison

Categories

(Firefox for Android Graveyard :: Android Sync, defect, P2)

Product:
Firefox for Android Graveyard
Component:
Android Sync
Platform:
ARM
Android
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dchanm+bugzilla, Unassigned)

References

Details

An object reference comparison is used to compare the guid properties of the record type. [1] guid is defined as a String in [2] so equals() or compareTo() should be used instead. [1] - https://github.com/mozilla-services/android-sync/blob/master/src/main/java/org/mozilla/gecko/sync/repositories/android/AndroidBrowserRepositorySession.java#L525 [2] - https://github.com/mozilla-services/android-sync/blob/master/src/main/java/org/mozilla/gecko/sync/repositories/domain/Record.java#L48
No longer the case after Bug 709348 lands. It rewrites all this code.
Depends on: 709348
Blocks: 723230
Priority: -- → P2
As of https://github.com/mozilla-services/android-sync/commit/26dbaf947aac59bb2a4c3571c947269e0dd78cc7 Every use of == in `find android-sync/src/main/java/org/mozilla/gecko/sync/repositories` looks good to me. Can we close this?
I'll take your word for it, Nick, after Comment 1.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: Mozilla Services → Android Background Services
Product: Android Background Services → Firefox for Android
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.