Home page shows set up banner even though Sync was just set up

VERIFIED FIXED in Firefox 11

Status

()

Firefox for Android
General
VERIFIED FIXED
5 years ago
9 months ago

People

(Reporter: tracy, Assigned: lucasr)

Tracking

unspecified
Firefox 13
ARM
All
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed, firefox13 fixed, fennec+)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
After connection mobile device (in this Samsung 10.1 tab), Return to Aurora start page shows the set up sync banner across the top sites section of that page.  reloading the page makes the banner go away.

expected results:  the start page should not sow the setup banner once the device has been connected to an account.
Component: Android Sync → General
Product: Mozilla Services → Fennec Native
QA Contact: android-sync → general
Hey Tracy, this is bug 721354 which landed yesterday on Aurora. Can you try today's build?
(Reporter)

Comment 2

5 years ago
Aaron, build is Mozilla/5.0 (Android; Linux armv7l; rv:11.0a2) Gecko/20120131 Firefox/11.0a2 Fennec/11.oa2  on Samsung Galaxy Tab 10.1

Doesn't appear both birds got got.
(In reply to Tracy Walker [:tracy] from comment #2)
> Aaron, build is Mozilla/5.0 (Android; Linux armv7l; rv:11.0a2)
> Gecko/20120131 Firefox/11.0a2 Fennec/11.oa2  on Samsung Galaxy Tab 10.1
> 
> Doesn't appear both birds got got.

Lucas?
Blocks: 721354
(Assignee)

Comment 4

5 years ago
Created attachment 593454 [details] [diff] [review]
Show/hide sync banner when sync accounts are added/removed
Attachment #593454 - Flags: review?(mark.finkle)

Updated

5 years ago
status-firefox11: --- → affected
status-firefox12: --- → affected
status-firefox13: --- → affected
Attachment #593454 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 5

5 years ago
Pushed: http://hg.mozilla.org/integration/mozilla-inbound/rev/36fb43ea8f0c
(Assignee)

Comment 6

5 years ago
Comment on attachment 593454 [details] [diff] [review]
Show/hide sync banner when sync accounts are added/removed

Important UX fix for about:home. Non-risky.
Attachment #593454 - Flags: approval-mozilla-beta?
Attachment #593454 - Flags: approval-mozilla-aurora?

Updated

5 years ago
tracking-fennec: --- → +
https://hg.mozilla.org/mozilla-central/rev/36fb43ea8f0c
Assignee: nobody → lucasr.at.mozilla
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13

Updated

5 years ago
status-firefox13: affected → ---

Comment 8

5 years ago
Comment on attachment 593454 [details] [diff] [review]
Show/hide sync banner when sync accounts are added/removed

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.
Attachment #593454 - Flags: approval-mozilla-beta?
Attachment #593454 - Flags: approval-mozilla-beta+
Attachment #593454 - Flags: approval-mozilla-aurora?
Attachment #593454 - Flags: approval-mozilla-aurora+
Verified fixed on:

Firefox 13.0a1 (2012-02-06)
20120206031148
http://hg.mozilla.org/mozilla-central/rev/814d0b2dbaba
Device: HTC Desire Z
OS: Android 2.3.3

Firefox 12.0a2 (2012-02-06)
20120206042011
http://hg.mozilla.org/releases/mozilla-aurora/rev/9fb0c06ceb49
Device: HTC Desire Z
OS: Android 2.3.3

Firefox 11.0
20120206042108
http://hg.mozilla.org/releases/mozilla-beta/rev/6a71fe8b7ada
Device: HTC Desire Z
OS: Android 2.3.3
Status: RESOLVED → VERIFIED
status-firefox11: affected → fixed
status-firefox12: affected → fixed
status-firefox13: --- → fixed
https://hg.mozilla.org/releases/mozilla-aurora/rev/b1cd565bc999

(has not landed on fx11 yet)
status-firefox11: fixed → affected
https://hg.mozilla.org/releases/mozilla-beta/rev/8381446b37ca
status-firefox11: affected → fixed
You need to log in before you can comment on or make changes to this bug.