Closed
Bug 722840
Opened 14 years ago
Closed 14 years ago
Add inherited private browsing attribute to docshells
Categories
(Core :: DOM: Navigation, defect)
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: jdm, Assigned: jdm)
References
Details
Attachments
(1 file, 3 obsolete files)
|
6.63 KB,
patch
|
Details | Diff | Splinter Review |
A given docshell will be the canonical way to determine the state of Private Browsing in the brave new per-window world.
|
Assignee | |
Comment 1•14 years ago
|
||
|
|
Assignee | |
Comment 2•14 years ago
|
||
The intent here is to have a flag that propagates to all children. Does this look right to you?
Attachment #593333 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•14 years ago
|
Attachment #593331 -
Attachment is obsolete: true
|
||
Comment 3•14 years ago
|
||
Comment on attachment 593333 [details] [diff] [review]
Add private browsing attribute to docshells.
Per IRC discussion, you should remove the changes to RestoreFromHistory and replace them with a comment that we want to pick up the parent's mInPrivateBrowsing (similar to the comment about mIsActive).
r=me with that.
Attachment #593333 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Attachment #593333 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Attachment #593567 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [autoland]
|
|
||
Updated•14 years ago
|
Whiteboard: [autoland] → [autoland-in-queue]
|
|
||
Comment 6•14 years ago
|
||
Autoland Patchset:
Patches: 593597
Branch: mozilla-central => try
Could not apply and push patchset:
Failed to push
|
|
||
Updated•14 years ago
|
Whiteboard: [autoland-in-queue]
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [autoland]
|
|
||
Updated•14 years ago
|
Whiteboard: [autoland] → [autoland-in-queue]
|
|
||
Comment 7•14 years ago
|
||
Autoland Patchset:
Patches: 593597
Branch: mozilla-central => try
Could not apply and push patchset:
Failed to push
|
|
||
Updated•14 years ago
|
Whiteboard: [autoland-in-queue]
|
|
Assignee | |
Comment 8•14 years ago
|
||
|
|
||
Comment 9•14 years ago
|
||
Assignee: nobody → josh
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•