Add inherited private browsing attribute to docshells

RESOLVED FIXED in mozilla13

Status

()

Core
Document Navigation
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jdm, Assigned: jdm)

Tracking

Trunk
mozilla13
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

5 years ago
A given docshell will be the canonical way to determine the state of Private Browsing in the brave new per-window world.
(Assignee)

Updated

5 years ago
Blocks: 722845
(Assignee)

Updated

5 years ago
Blocks: 722857
(Assignee)

Updated

5 years ago
Blocks: 722864
(Assignee)

Updated

5 years ago
Blocks: 722976
(Assignee)

Updated

5 years ago
Blocks: 722977
(Assignee)

Updated

5 years ago
Blocks: 722978
(Assignee)

Updated

5 years ago
Blocks: 722982
(Assignee)

Updated

5 years ago
Blocks: 722984
(Assignee)

Updated

5 years ago
Blocks: 722986
(Assignee)

Updated

5 years ago
Blocks: 722988
(Assignee)

Updated

5 years ago
Blocks: 722994
(Assignee)

Updated

5 years ago
Blocks: 722995
(Assignee)

Updated

5 years ago
Blocks: 722996
(Assignee)

Updated

5 years ago
Blocks: 723003
(Assignee)

Updated

5 years ago
Blocks: 723004
(Assignee)

Updated

5 years ago
Blocks: 723018
(Assignee)

Comment 1

5 years ago
Created attachment 593331 [details] [diff] [review]
Add private browsing attribute to docshells.
(Assignee)

Comment 2

5 years ago
Created attachment 593333 [details] [diff] [review]
Add private browsing attribute to docshells.

The intent here is to have a flag that propagates to all children. Does this look right to you?
Attachment #593333 - Flags: review?(bzbarsky)
(Assignee)

Updated

5 years ago
Attachment #593331 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Blocks: 722853
Comment on attachment 593333 [details] [diff] [review]
Add private browsing attribute to docshells.

Per IRC discussion, you should remove the changes to RestoreFromHistory and replace them with a comment that we want to pick up the parent's mInPrivateBrowsing (similar to the comment about mIsActive).

r=me with that.
Attachment #593333 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 4

5 years ago
Created attachment 593567 [details] [diff] [review]
Add private browsing attribute to docshells.
(Assignee)

Updated

5 years ago
Attachment #593333 - Attachment is obsolete: true
(Assignee)

Comment 5

5 years ago
Created attachment 593597 [details] [diff] [review]
Add private browsing attribute to docshells.
(Assignee)

Updated

5 years ago
Attachment #593567 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Whiteboard: [autoland]

Updated

5 years ago
Whiteboard: [autoland] → [autoland-in-queue]

Comment 6

5 years ago
Autoland Patchset:
	Patches: 593597
	Branch: mozilla-central => try
Could not apply and push patchset:
Failed to push

Updated

5 years ago
Whiteboard: [autoland-in-queue]
(Assignee)

Updated

5 years ago
Whiteboard: [autoland]

Updated

5 years ago
Whiteboard: [autoland] → [autoland-in-queue]

Comment 7

5 years ago
Autoland Patchset:
	Patches: 593597
	Branch: mozilla-central => try
Could not apply and push patchset:
Failed to push

Updated

5 years ago
Whiteboard: [autoland-in-queue]
(Assignee)

Updated

5 years ago
Blocks: 723353
(Assignee)

Comment 8

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/81a9428d00f1

Comment 9

5 years ago
https://hg.mozilla.org/mozilla-central/rev/81a9428d00f1
Assignee: nobody → josh
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.