Last Comment Bug 722840 - Add inherited private browsing attribute to docshells
: Add inherited private browsing attribute to docshells
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Document Navigation (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla13
Assigned To: Josh Matthews [:jdm]
:
Mentors:
Depends on:
Blocks: PBnGen 722845 722853 722857 722864 722976 722977 722978 722982 722984 722986 722988 722994 722995 722996 723003 723004 723018 723353
  Show dependency treegraph
 
Reported: 2012-01-31 13:30 PST by Josh Matthews [:jdm]
Modified: 2012-02-05 04:05 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Add private browsing attribute to docshells. (6.32 KB, patch)
2012-02-01 01:08 PST, Josh Matthews [:jdm]
no flags Details | Diff | Splinter Review
Add private browsing attribute to docshells. (6.31 KB, patch)
2012-02-01 01:12 PST, Josh Matthews [:jdm]
bzbarsky: review+
Details | Diff | Splinter Review
Add private browsing attribute to docshells. (6.68 KB, patch)
2012-02-01 12:35 PST, Josh Matthews [:jdm]
no flags Details | Diff | Splinter Review
Add private browsing attribute to docshells. (6.63 KB, patch)
2012-02-01 13:50 PST, Josh Matthews [:jdm]
no flags Details | Diff | Splinter Review

Description Josh Matthews [:jdm] 2012-01-31 13:30:24 PST
A given docshell will be the canonical way to determine the state of Private Browsing in the brave new per-window world.
Comment 1 Josh Matthews [:jdm] 2012-02-01 01:08:19 PST
Created attachment 593331 [details] [diff] [review]
Add private browsing attribute to docshells.
Comment 2 Josh Matthews [:jdm] 2012-02-01 01:12:33 PST
Created attachment 593333 [details] [diff] [review]
Add private browsing attribute to docshells.

The intent here is to have a flag that propagates to all children. Does this look right to you?
Comment 3 Boris Zbarsky [:bz] 2012-02-01 11:13:11 PST
Comment on attachment 593333 [details] [diff] [review]
Add private browsing attribute to docshells.

Per IRC discussion, you should remove the changes to RestoreFromHistory and replace them with a comment that we want to pick up the parent's mInPrivateBrowsing (similar to the comment about mIsActive).

r=me with that.
Comment 4 Josh Matthews [:jdm] 2012-02-01 12:35:26 PST
Created attachment 593567 [details] [diff] [review]
Add private browsing attribute to docshells.
Comment 5 Josh Matthews [:jdm] 2012-02-01 13:50:29 PST
Created attachment 593597 [details] [diff] [review]
Add private browsing attribute to docshells.
Comment 6 Mozilla RelEng Bot 2012-02-01 13:55:44 PST
Autoland Patchset:
	Patches: 593597
	Branch: mozilla-central => try
Could not apply and push patchset:
Failed to push
Comment 7 Mozilla RelEng Bot 2012-02-01 14:22:14 PST
Autoland Patchset:
	Patches: 593597
	Branch: mozilla-central => try
Could not apply and push patchset:
Failed to push
Comment 9 Ed Morley [:emorley] 2012-02-05 04:05:14 PST
https://hg.mozilla.org/mozilla-central/rev/81a9428d00f1

Note You need to log in before you can comment on or make changes to this bug.