Closed Bug 722840 Opened 11 years ago Closed 11 years ago

Add inherited private browsing attribute to docshells

Categories

(Core :: DOM: Navigation, defect)

Product:
Core
Component:
DOM: Navigation
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla13

People

(Reporter: jdm, Assigned: jdm)

References

Details

Attachments

(1 file, 3 obsolete files)

Add private browsing attribute to docshells.
6.63 KB, patch
Details | Diff | Splinter Review 
A given docshell will be the canonical way to determine the state of Private Browsing in the brave new per-window world.
Blocks: 722845
Blocks: 722857
Blocks: 722864
Blocks: 722976
Blocks: 722977
Blocks: 722978
Blocks: 722982
Blocks: 722984
Blocks: 722986
Blocks: 722988
Blocks: 722994
Blocks: 722995
Blocks: 722996
Blocks: 723003
Blocks: 723004
Blocks: 723018
The intent here is to have a flag that propagates to all children. Does this look right to you?
Attachment #593333 - Flags: review?(bzbarsky)
Attachment #593331 - Attachment is obsolete: true
Blocks: 722853
Comment on attachment 593333 [details] [diff] [review]
Add private browsing attribute to docshells.

Per IRC discussion, you should remove the changes to RestoreFromHistory and replace them with a comment that we want to pick up the parent's mInPrivateBrowsing (similar to the comment about mIsActive).

r=me with that.
Attachment #593333 - Flags: review?(bzbarsky) → review+
Attachment #593333 - Attachment is obsolete: true
Attachment #593567 - Attachment is obsolete: true
Whiteboard: [autoland]
Whiteboard: [autoland] → [autoland-in-queue]
Autoland Patchset:
	Patches: 593597
	Branch: mozilla-central => try
Could not apply and push patchset:
Failed to push
Whiteboard: [autoland-in-queue]
Whiteboard: [autoland]
Whiteboard: [autoland] → [autoland-in-queue]
Autoland Patchset:
	Patches: 593597
	Branch: mozilla-central => try
Could not apply and push patchset:
Failed to push
Whiteboard: [autoland-in-queue]
Blocks: 723353
https://hg.mozilla.org/mozilla-central/rev/81a9428d00f1
Assignee: nobody → josh
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.