Last Comment Bug 723018 - Toggle the private browsing attribute of all root docshells when transitioning through private browsing mode
: Toggle the private browsing attribute of all root docshells when transitionin...
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Private Browsing (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: Firefox 13
Assigned To: Josh Matthews [:jdm]
:
Mentors:
Depends on: 722840
Blocks: PBnGen
  Show dependency treegraph
 
Reported: 2012-02-01 01:05 PST by Josh Matthews [:jdm]
Modified: 2012-02-08 10:15 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Toggle the private browsing attribute of all root docshells when triggering private browsing mode. (3.52 KB, patch)
2012-02-01 01:07 PST, Josh Matthews [:jdm]
no flags Details | Diff | Splinter Review
Toggle the private browsing attribute of all root docshells when triggering private browsing mode. (3.57 KB, patch)
2012-02-01 12:48 PST, Josh Matthews [:jdm]
ehsan: review+
Details | Diff | Splinter Review

Description Josh Matthews [:jdm] 2012-02-01 01:05:43 PST
To support developing per-window-pb in incrementally and in parallel with the existing code, we want to make the docshell attribute equivalent to using the existing global service.
Comment 1 Josh Matthews [:jdm] 2012-02-01 01:07:55 PST
Created attachment 593330 [details] [diff] [review]
Toggle the private browsing attribute of all root docshells when triggering private browsing mode.
Comment 2 Josh Matthews [:jdm] 2012-02-01 12:48:53 PST
Created attachment 593574 [details] [diff] [review]
Toggle the private browsing attribute of all root docshells when triggering private browsing mode.
Comment 3 Mozilla RelEng Bot 2012-02-02 02:15:19 PST
Try run for 9953cd9e45ce is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=9953cd9e45ce
Results (out of 83 total builds):
    success: 72
    warnings: 11
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/josh@joshmatthews.net-9953cd9e45ce
Comment 4 :Ehsan Akhgari (away Aug 1-5) 2012-02-06 11:19:13 PST
Comment on attachment 593574 [details] [diff] [review]
Toggle the private browsing attribute of all root docshells when triggering private browsing mode.

Review of attachment 593574 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Comment 6 Ed Morley [:emorley] 2012-02-07 12:14:01 PST
https://hg.mozilla.org/mozilla-central/rev/9cececa8ebfd
Comment 7 :Ms2ger (⌚ UTC+1/+2) 2012-02-08 10:15:52 PST
Comment on attachment 593574 [details] [diff] [review]
Toggle the private browsing attribute of all root docshells when triggering private browsing mode.

>-        // if there are open browser windows, load a dummy session to get a distinct 
>+	// if there are open browser windows, load a dummy session to get a distinct 
>         // separation between private and non-private sessions
>-        if (browserWindow) {
>+	if (browserWindow) {

Tabs!

Note You need to log in before you can comment on or make changes to this bug.