723018 - Toggle the private browsing attribute of all root docshells when transitioning through private browsing mode

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[Josh Matthews [:jdm]]

To support developing per-window-pb in incrementally and in parallel with the existing code, we want to make the docshell attribute equivalent to using the existing global service.

Comment 1

[Josh Matthews [:jdm]]

Attachment: Toggle the private browsing attribute of all root docshells when triggering private browsing mode.

Comment 2

[Josh Matthews [:jdm]]

Attachment: Toggle the private browsing attribute of all root docshells when triggering private browsing mode.

Comment 3

[Mozilla RelEng Bot]

Try run for 9953cd9e45ce is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=9953cd9e45ce
Results (out of 83 total builds):
    success: 72
    warnings: 11
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-9953cd9e45ce

Comment 4

[(no longer active)]

Comment on attachment 593574 [details] [diff] [review]
Toggle the private browsing attribute of all root docshells when triggering private browsing mode.

Review of attachment 593574 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 5

[Josh Matthews [:jdm]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/9cececa8ebfd

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9cececa8ebfd

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 593574 [details] [diff] [review]
Toggle the private browsing attribute of all root docshells when triggering private browsing mode.

>-        // if there are open browser windows, load a dummy session to get a distinct 
>+	// if there are open browser windows, load a dummy session to get a distinct 
>         // separation between private and non-private sessions
>-        if (browserWindow) {
>+	if (browserWindow) {

Tabs!