Closed
Bug 723018
Opened 12 years ago
Closed 12 years ago
Toggle the private browsing attribute of all root docshells when transitioning through private browsing mode
Categories
(Firefox :: Private Browsing, defect)
Tracking
()
RESOLVED
FIXED
Firefox 13
People
(Reporter: jdm, Assigned: jdm)
References
Details
Attachments
(1 file, 1 obsolete file)
|
3.57 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
To support developing per-window-pb in incrementally and in parallel with the existing code, we want to make the docshell attribute equivalent to using the existing global service.
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Attachment #593330 -
Attachment is obsolete: true
|
||
Comment 3•12 years ago
|
||
Try run for 9953cd9e45ce is complete.
Detailed breakdown of the results available here:
https://tbpl.mozilla.org/?tree=Try&rev=9953cd9e45ce
Results (out of 83 total builds):
success: 72
warnings: 11
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/josh@joshmatthews.net-9953cd9e45ce|
|
Assignee | |
Updated•12 years ago
|
Attachment #593574 -
Flags: review?(ehsan)
|
||
Comment 4•12 years ago
|
||
Comment on attachment 593574 [details] [diff] [review] Toggle the private browsing attribute of all root docshells when triggering private browsing mode. Review of attachment 593574 [details] [diff] [review]: ----------------------------------------------------------------- Looks good!
Attachment #593574 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/9cececa8ebfd
|
||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9cececa8ebfd
Assignee: nobody → josh
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
|
||
Comment 7•12 years ago
|
||
Comment on attachment 593574 [details] [diff] [review] Toggle the private browsing attribute of all root docshells when triggering private browsing mode. >- // if there are open browser windows, load a dummy session to get a distinct >+ // if there are open browser windows, load a dummy session to get a distinct > // separation between private and non-private sessions >- if (browserWindow) { >+ if (browserWindow) { Tabs!
You need to log in
before you can comment on or make changes to this bug.
Description
•