The default bug view has changed. See this FAQ.

Toggle the private browsing attribute of all root docshells when transitioning through private browsing mode

RESOLVED FIXED in Firefox 13

Status

()

Firefox
Private Browsing
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jdm, Assigned: jdm)

Tracking

unspecified
Firefox 13
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
To support developing per-window-pb in incrementally and in parallel with the existing code, we want to make the docshell attribute equivalent to using the existing global service.
(Assignee)

Comment 1

5 years ago
Created attachment 593330 [details] [diff] [review]
Toggle the private browsing attribute of all root docshells when triggering private browsing mode.
(Assignee)

Comment 2

5 years ago
Created attachment 593574 [details] [diff] [review]
Toggle the private browsing attribute of all root docshells when triggering private browsing mode.
(Assignee)

Updated

5 years ago
Attachment #593330 - Attachment is obsolete: true

Comment 3

5 years ago
Try run for 9953cd9e45ce is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=9953cd9e45ce
Results (out of 83 total builds):
    success: 72
    warnings: 11
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/josh@joshmatthews.net-9953cd9e45ce
(Assignee)

Updated

5 years ago
Attachment #593574 - Flags: review?(ehsan)
Comment on attachment 593574 [details] [diff] [review]
Toggle the private browsing attribute of all root docshells when triggering private browsing mode.

Review of attachment 593574 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #593574 - Flags: review?(ehsan) → review+
(Assignee)

Comment 5

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/9cececa8ebfd
https://hg.mozilla.org/mozilla-central/rev/9cececa8ebfd
Assignee: nobody → josh
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Comment on attachment 593574 [details] [diff] [review]
Toggle the private browsing attribute of all root docshells when triggering private browsing mode.

>-        // if there are open browser windows, load a dummy session to get a distinct 
>+	// if there are open browser windows, load a dummy session to get a distinct 
>         // separation between private and non-private sessions
>-        if (browserWindow) {
>+	if (browserWindow) {

Tabs!
You need to log in before you can comment on or make changes to this bug.