722962 - intermittent failure in /tests/content/base/test/test_XHR.html | hello pass

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Phil Ringnalda (:philor)]

+++ This bug was initially created as a clone of Bug #656253 +++

https://tbpl.mozilla.org/php/getParsedLog.php?id=8972541&tree=Firefox
Rev3 WINNT 5.1 mozilla-central opt test mochitests-1/5 on 2012-01-31 05:03:58

6764 ERROR TEST-UNEXPECTED-FAIL | /tests/content/base/test/test_XHR.html | hello pass

https://tbpl.mozilla.org/php/getParsedLog.php?id=8991612&tree=Mozilla-Inbound
Rev3 WINNT 6.1 mozilla-inbound opt test mochitests-1/5 on 2012-01-31 17:06:47

6764 ERROR TEST-UNEXPECTED-FAIL | /tests/content/base/test/test_XHR.html | hello pass

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: patch

|var fr| can race after bug 696586 because it is executed twice now.
Wrapped the code in an anonymous function to avoid the race.
Also added |"use strict";| directive.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Can you explain what's happening here?

I don't see how runTests is run twice, and even if it was, 'fr' is a local variable so it will go out of scope after the first run, no?

Nit: please put the "use strict" on a separate line.

Comment 3

[Masatoshi Kimura [:emk]]

(In reply to Jonas Sicking (:sicking) from comment #2)
|var fr = new FileReader();| at line 237 will be executed twice because a for-loop has been added by bug 696586 (from line 218 to line 302).
'fr' will be overwritten even if it is a local variable because the for-loop will not create a independent scope. I added a anonymous function to create a new scope for every execute.

Comment 4

[Masatoshi Kimura [:emk]]

Attachment: patch v2

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 593626 [details] [diff] [review]
patch v2

Review of attachment 593626 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if you also fix the indentation in this file. Both the fact that this whole thing is wrapped in a function, and the for-loop is all too easy to miss.

Comment 6

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=9023094&tree=Mozilla-Aurora
Rev3 WINNT 6.1 mozilla-aurora pgo test mochitests-1/5 on 2012-02-01 19:42:45

6765 ERROR TEST-UNEXPECTED-FAIL | /tests/content/base/test/test_XHR.html | hello pass

Comment 7

[Legacy TBPL/Treeherder Robot]

rnewman
https://tbpl.mozilla.org/php/getParsedLog.php?id=9023094&tree=Mozilla-Aurora
Rev3 WINNT 6.1 mozilla-aurora pgo test mochitests-1/5 on 2012-02-01 19:42:45

6765 ERROR TEST-UNEXPECTED-FAIL | /tests/content/base/test/test_XHR.html | hello pass

Comment 8

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=9015773&tree=Fx-Team
Rev3 WINNT 6.1 fx-team opt test mochitests-1/5 on 2012-02-01 14:44:12

6764 ERROR TEST-UNEXPECTED-FAIL | /tests/content/base/test/test_XHR.html | hello pass

Comment 9

[Masatoshi Kimura [:emk]]

Attachment: patch for check in; r=jonas

Comment 10

[Masatoshi Kimura [:emk]]

Attachment: patch for check in; r=jonas

Sorry, the previous patch didn't pass the test

Comment 11

[Legacy TBPL/Treeherder Robot]

mbrubeck
https://tbpl.mozilla.org/php/getParsedLog.php?id=9044960&tree=Mozilla-Aurora
Rev3 WINNT 5.1 mozilla-aurora pgo test mochitests-1/5 on 2012-02-02 14:08:02

6764 ERROR TEST-UNEXPECTED-FAIL | /tests/content/base/test/test_XHR.html | hello pass

Comment 12

[Legacy TBPL/Treeherder Robot]

sgautherie
https://tbpl.mozilla.org/php/getParsedLog.php?id=9046451&tree=Firefox
Rev3 WINNT 6.1 mozilla-central pgo test mochitests-1/5 on 2012-02-02 15:17:34

6764 ERROR TEST-UNEXPECTED-FAIL | /tests/content/base/test/test_XHR.html | hello pass

Comment 13

[Legacy TBPL/Treeherder Robot]

jfkthame%gmail.com
https://tbpl.mozilla.org/php/getParsedLog.php?id=9071604&tree=Mozilla-Inbound
Rev3 WINNT 6.1 mozilla-inbound pgo test mochitests-1/5 on 2012-02-03 12:28:20

6764 ERROR TEST-UNEXPECTED-FAIL | /tests/content/base/test/test_XHR.html | hello pass

Comment 14

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 593798
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/f1b3301da9a5
Try run started, revision f1b3301da9a5. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=f1b3301da9a5

Comment 15

[Mozilla RelEng Bot]

Try run for f1b3301da9a5 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=f1b3301da9a5
Results (out of 206 total builds):
    success: 185
    warnings: 21
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-f1b3301da9a5
 Timed out after 06 hours without completing.

Comment 16

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1d89a17aacbe

Comment 17

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1d89a17aacbe

Comment 18

[Alex Keybl [:akeybl]]

We don't typically track a test-only change for release, but we'll gladly accept a nomination to fix this orange on Aurora 12.

Comment 19

[Masatoshi Kimura [:emk]]

Comment on attachment 593798 [details] [diff] [review]
patch for check in; r=jonas

[Approval Request Comment]
Regression caused by (bug #): bug 696586
User impact if declined: None (test only)
Testing completed (on m-c, etc.): No test orange on m-c for 5 days
Risk to taking this patch (and alternatives if risky): None (test only)
String changes made by this patch: None

Comment 20

[Alex Keybl [:akeybl]]

Comment on attachment 593798 [details] [diff] [review]
patch for check in; r=jonas

[Triage Comment]
Approved for Aurora 12.

Comment 21

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-aurora/rev/5d0815d5f980