intermittent failure in /tests/content/base/test/test_XHR.html | hello pass

RESOLVED FIXED in Firefox 12

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: philor, Assigned: emk)

Tracking

({intermittent-failure, regression})

Trunk
mozilla13
intermittent-failure, regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox11 unaffected, firefox12- fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

6 years ago
+++ This bug was initially created as a clone of Bug #656253 +++

https://tbpl.mozilla.org/php/getParsedLog.php?id=8972541&tree=Firefox
Rev3 WINNT 5.1 mozilla-central opt test mochitests-1/5 on 2012-01-31 05:03:58

6764 ERROR TEST-UNEXPECTED-FAIL | /tests/content/base/test/test_XHR.html | hello pass

https://tbpl.mozilla.org/php/getParsedLog.php?id=8991612&tree=Mozilla-Inbound
Rev3 WINNT 6.1 mozilla-inbound opt test mochitests-1/5 on 2012-01-31 17:06:47

6764 ERROR TEST-UNEXPECTED-FAIL | /tests/content/base/test/test_XHR.html | hello pass
(Assignee)

Comment 1

6 years ago
Created attachment 593371 [details] [diff] [review]
patch

|var fr| can race after bug 696586 because it is executed twice now.
Wrapped the code in an anonymous function to avoid the race.
Also added |"use strict";| directive.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #593371 - Flags: review?(jonas)
(Assignee)

Updated

6 years ago
Blocks: 696586
Can you explain what's happening here?

I don't see how runTests is run twice, and even if it was, 'fr' is a local variable so it will go out of scope after the first run, no?

Nit: please put the "use strict" on a separate line.
(Assignee)

Comment 3

6 years ago
(In reply to Jonas Sicking (:sicking) from comment #2)
|var fr = new FileReader();| at line 237 will be executed twice because a for-loop has been added by bug 696586 (from line 218 to line 302).
'fr' will be overwritten even if it is a local variable because the for-loop will not create a independent scope. I added a anonymous function to create a new scope for every execute.
(Assignee)

Comment 4

6 years ago
Created attachment 593626 [details] [diff] [review]
patch v2
Attachment #593626 - Flags: review?(jonas)
(Assignee)

Updated

6 years ago
Attachment #593371 - Attachment is obsolete: true
Attachment #593371 - Flags: review?(jonas)
Comment on attachment 593626 [details] [diff] [review]
patch v2

Review of attachment 593626 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if you also fix the indentation in this file. Both the fact that this whole thing is wrapped in a function, and the for-loop is all too easy to miss.
Attachment #593626 - Flags: review?(jonas) → review+
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 9

6 years ago
Created attachment 593794 [details] [diff] [review]
patch for check in; r=jonas
Attachment #593626 - Attachment is obsolete: true
Attachment #593794 - Flags: review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
(Assignee)

Comment 10

6 years ago
Created attachment 593798 [details] [diff] [review]
patch for check in; r=jonas

Sorry, the previous patch didn't pass the test
Attachment #593794 - Attachment is obsolete: true
Attachment #593798 - Flags: review+
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)

Updated

6 years ago
Whiteboard: [orange] → [orange] [autoland-try]

Updated

6 years ago
Whiteboard: [orange] [autoland-try] → [orange] [autoland-in-queue]

Comment 14

6 years ago
Autoland Patchset:
	Patches: 593798
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/f1b3301da9a5
Try run started, revision f1b3301da9a5. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=f1b3301da9a5
(Assignee)

Updated

6 years ago
status-firefox11: --- → unaffected
status-firefox12: --- → affected
tracking-firefox12: --- → ?
Keywords: regression

Comment 15

6 years ago
Try run for f1b3301da9a5 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=f1b3301da9a5
Results (out of 206 total builds):
    success: 185
    warnings: 21
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-f1b3301da9a5
 Timed out after 06 hours without completing.
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d89a17aacbe
Keywords: checkin-needed
Whiteboard: [orange] [autoland-in-queue] → [orange]
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/1d89a17aacbe
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
We don't typically track a test-only change for release, but we'll gladly accept a nomination to fix this orange on Aurora 12.
tracking-firefox12: ? → -
(Assignee)

Comment 19

6 years ago
Comment on attachment 593798 [details] [diff] [review]
patch for check in; r=jonas

[Approval Request Comment]
Regression caused by (bug #): bug 696586
User impact if declined: None (test only)
Testing completed (on m-c, etc.): No test orange on m-c for 5 days
Risk to taking this patch (and alternatives if risky): None (test only)
String changes made by this patch: None
Attachment #593798 - Flags: approval-mozilla-aurora?
Comment on attachment 593798 [details] [diff] [review]
patch for check in; r=jonas

[Triage Comment]
Approved for Aurora 12.
Attachment #593798 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Whiteboard: [orange] → [orange] [land to aurora]
http://hg.mozilla.org/releases/mozilla-aurora/rev/5d0815d5f980
status-firefox12: affected → fixed
Keywords: checkin-needed
Whiteboard: [orange] [land to aurora] → [orange]
Whiteboard: [orange] → [orange][qa-]
Keywords: intermittent-failure
Whiteboard: [orange][qa-] → [qa-]
You need to log in before you can comment on or make changes to this bug.