722983 - Private Browsing autostart relies on global service

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect)

Description

[Josh Matthews [:jdm]]

We'll want to make this trigger something that modifies docshells and so forth.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

This patch implements the basics here.  The UI for the per-window PB case is probably broken but I need to figure out how the UI should work before attempting to fix those cases.  I have filed bug 801823 for that.

Comment 3

[(no longer active)]

Comment on attachment 671574 [details] [diff] [review]
Patch (v1)

The risk here is medium, but we need this for 18, so we should take it ASAP.

Comment 4

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2dc84b223c27

Comment 5

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/2dc84b223c27

Comment 6

[bhavana bajaj [:bajaj]]

(In reply to Ehsan Akhgari [:ehsan] from comment #3)
> Comment on attachment 671574 [details] [diff] [review]
> Patch (v1)
> 
> The risk here is medium, but we need this for 18, so we should take it ASAP.

Whats the user impact for non Per-wind-PB users on FF18 here considering this is a medium risk one ?

Comment 7

[(no longer active)]

Without this, permanent private browsing will be broken.  I think we should definitely take this patch, but should watch for regressions on central and aurora closely.  I'm not worried about the possibility of bugs skipping our attention before it's too late here.

Comment 8

[bhavana bajaj [:bajaj]]

Comment on attachment 671574 [details] [diff] [review]
Patch (v1)

Thanks for the quick reply, Ehsan ! Approving it for Aurora based on comment 7

Comment 9

[(no longer active)]

I was confused here, sorry.  But 798508 never landed for 18, so this is not needed.

Comment 10

[Mihai Morar, (:MihaiMorar)]

Looks to work as expected on FF 19b1 

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:19.0) Gecko/20100101 Firefox/19.0 (20130109111322)

Comment 11

[Mihai Morar, (:MihaiMorar)]

(In reply to MarioMi from comment #10)
> Looks to work as expected on FF 19b1 
> 
> Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:19.0) Gecko/20100101
> Firefox/19.0 (20130109111322)

Can anyone still reproduce this issue on FF 19b ?

Comment 12

[(no longer active)]

(In reply to comment #11)
> (In reply to MarioMi from comment #10)
> > Looks to work as expected on FF 19b1 
> > 
> > Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:19.0) Gecko/20100101
> > Firefox/19.0 (20130109111322)
> 
> Can anyone still reproduce this issue on FF 19b ?

I believe this should be fixed.

Comment 13

[Mihai Morar, (:MihaiMorar)]

Resolved Fixed on FF 20b5 on Mac OS 10.8 too, based on my verification and on Comment 12. If anyone can still repro this issue please reopen it.