801899 - Assertion failure: false @ mozilla::places::AsyncFetchAndSetIconForPage::AsyncFetchAndSetIconForPage with Private Browsing

Status: RESOLVED DUPLICATE of bug 722983

(Core :: Networking, defect)

Description

[Bob Clary [:bc] (inactive)]

1. Enable Private Browsing via preferences-> Privacy -> Never remember History
2. Start Browser
3. Assert OSX 10.6 and RHEL6 32bit. I couldn't reproduce on RHEL6 64bit. Haven't tried windows.

Assertion failure: false, at /work/mozilla/builds/nightly/mozilla/toolkit/components/places/AsyncFaviconHelpers.cpp:527

#0  mozilla::places::AsyncFetchAndSetIconForPage::AsyncFetchAndSetIconForPage (this=0x11aec67b0, aIcon=@0x7fff5fbf8778, aPage=@0x7fff5fbf8800, aFaviconLoadType=2, aCallback=@0x7fff5fbf8750)
    at /work/mozilla/builds/nightly/mozilla/toolkit/components/places/AsyncFaviconHelpers.cpp:527
#1  0x0000000102ef3e23 in mozilla::places::AsyncFetchAndSetIconForPage::AsyncFetchAndSetIconForPage (this=0x11aec67b0, aIcon=@0x7fff5fbf8778, aPage=@0x7fff5fbf8800, aFaviconLoadType=2, aCallback=@0x7fff5fbf8750)
    at /work/mozilla/builds/nightly/mozilla/toolkit/components/places/AsyncFaviconHelpers.cpp:533
#2  0x0000000102ef3cbe in mozilla::places::AsyncFetchAndSetIconForPage::start (aFaviconURI=0x11e41a260, aPageURI=0x11aeb9510, aFetchMode=mozilla::places::FETCH_IF_MISSING, aFaviconLoadType=2, aCallback=0x0)
    at /work/mozilla/builds/nightly/mozilla/toolkit/components/places/AsyncFaviconHelpers.cpp:489
#3  0x0000000102e5db68 in nsFaviconService::SetAndLoadFaviconForPage (this=0x10acc91d0, aPageURI=0x11aeb9510, aFaviconURI=0x11e41a260, aForceReload=false, aFaviconLoadType=2, aCallback=0x0)
    at /work/mozilla/builds/nightly/mozilla/toolkit/components/places/nsFaviconService.cpp:369
#4  0x0000000102e5df54 in nsFaviconService::SetAndFetchFaviconForPage (this=0x10acc91d0, aPageURI=0x11aeb9510, aFaviconURI=0x11e41a260, aForceReload=false, aFaviconLoadType=2, aCallback=0x0)
    at /work/mozilla/builds/nightly/mozilla/toolkit/components/places/nsFaviconService.cpp:386
#5  0x0000000102e5dfb6 in non-virtual thunk to nsFaviconService::SetAndFetchFaviconForPage(nsIURI*, nsIURI*, bool, unsigned int, nsIFaviconDataCallback*) ()
    at /work/mozilla/builds/nightly/mozilla/toolkit/components/places/nsFaviconService.cpp:386

This is a pretty recent regression. I'll bisect for it.

Comment 1

[(no longer active)]

My patch in bug 722983 fixes this.  Sorry that I had not caught this earlier.