CSS Class names for scopes shouldn't have spaces

RESOLVED FIXED in Firefox 13

Status

()

Firefox
Developer Tools: Debugger
P3
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: past, Assigned: vporof)

Tracking

Trunk
Firefox 13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

In debugger-view.js we currently use the scope name as its class name, leading to classes like "Local-scope" and "With block-scope". It would be nice to use more regular class names for scopes.
(Assignee)

Comment 1

5 years ago
I'll take this.
Assignee: nobody → vporof
(Assignee)

Comment 2

5 years ago
Created attachment 599593 [details] [diff] [review]
v1

Also fixed typos in DVP__addProperty documentation.
Attachment #599593 - Flags: review?(past)
Comment on attachment 599593 [details] [diff] [review]
v1

Review of attachment 599593 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #599593 - Flags: review?(past) → review+
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
Although I have to admit it bothers me that we are still using a localizable string as a class name, I hope that this won't create more problems in the future.
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
(Assignee)

Comment 5

5 years ago
(In reply to Panos Astithas [:past] from comment #4)
> Although I have to admit it bothers me that we are still using a localizable
> string as a class name, I hope that this won't create more problems in the
> future.

I can easily change this. However, we're not using it as a class name (it's just "scope"). We're using it as an id, and I don't think we're (or will be) querying it anywhere (because every scope is cached in DebuggerView.Properties).
(In reply to Victor Porof from comment #5)
> (In reply to Panos Astithas [:past] from comment #4)
> > Although I have to admit it bothers me that we are still using a localizable
> > string as a class name, I hope that this won't create more problems in the
> > future.
> 
> I can easily change this. However, we're not using it as a class name (it's
> just "scope"). We're using it as an id, and I don't think we're (or will be)
> querying it anywhere (because every scope is cached in
> DebuggerView.Properties).

I was mainly concerned with producing CSS errors in the console, but after reading the spec, I think it's fine:

http://www.w3.org/TR/CSS21/syndata.html#value-def-identifier
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/e1098816a74f
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/e1098816a74f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 13
You need to log in before you can comment on or make changes to this bug.