Created attachment 593453 [details] [diff] [review]
See also bug 723114.
This patch is just a quick fix. Clang warns on GetImageFromSourceSurface via -Wreturn-type and we build with -Werror=return-type.
*** Bug 723187 has been marked as a duplicate of this bug. ***
*** Bug 723284 has been marked as a duplicate of this bug. ***
And the next one :(
In file included from ../../../dist/include/nsCoreAnimationSupport.h:49:
../../../dist/include/nsIOSurface.h:48:7: error: redefinition of 'NSOpenGLContext' as different kind of symbol
That's bug 723618.
(Please can you set assignee when attaching patches, or if using bzexport, file a bug against it :-))
Is it possible to get this into mozilla-beta? Today I've tried several times to build Thunderbird 12 with Clang, but it failed constantly with the error from Bug 723187. It takes me a hour or so to find out what the problem is and to find this Bug. Thanks.
(In reply to Nomis101 from comment #8)
> Is it possible to get this into mozilla-beta? Today I've tried several times
> to build Thunderbird 12 with Clang, but it failed constantly with the error
> from Bug 723187. It takes me a hour or so to find out what the problem is
> and to find this Bug. Thanks.
You could just export "-Wreturn-type" to turn the error into a warning and let the build finish.
I've applied this patch to fix the error, maybe your workaround would also help. But I think more about all the other users who are trying to build Firefox/Thunderbird 12 with Clang and run into the same error.