723122 - fix clang build

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: fix build

See also bug 723114.

This patch is just a quick fix. Clang warns on GetImageFromSourceSurface via -Wreturn-type and we build with -Werror=return-type.

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=5a80e90839fd

Comment 4

[Rob Campbell [:rc] (:robcee)]

merge! merge!

Comment 5

[Gregor Wagner [:gwagner]]

And the next one :(
In file included from ../../../dist/include/nsCoreAnimationSupport.h:49:
../../../dist/include/nsIOSurface.h:48:7: error: redefinition of 'NSOpenGLContext' as different kind of symbol

Comment 6

[Joe Drew (not getting mail)]

That's bug 723618.

Comment 7

[Ed Morley [:emorley]]

(Please can you set assignee when attaching patches, or if using bzexport, file a bug against it :-))

https://hg.mozilla.org/mozilla-central/rev/5a80e90839fd

Comment 8

[Nomis101]

Is it possible to get this into mozilla-beta? Today I've tried several times to build Thunderbird 12 with Clang, but it failed constantly with the error from Bug 723187. It takes me a hour or so to find out what the problem is and to find this Bug. Thanks.

Comment 9

[Victor Porof [:vporof][:vp]]

(In reply to Nomis101 from comment #8)
> Is it possible to get this into mozilla-beta? Today I've tried several times
> to build Thunderbird 12 with Clang, but it failed constantly with the error
> from Bug 723187. It takes me a hour or so to find out what the problem is
> and to find this Bug. Thanks.

You could just export "-Wreturn-type" to turn the error into a warning and let the build finish.

Comment 10

[Nomis101]

I've applied this patch to fix the error, maybe your workaround would also help. But I think more about all the other users who are trying to build Firefox/Thunderbird 12 with Clang and run into the same error.