Closed Bug 723138 Opened 8 years ago Closed 8 years ago

Language packs should work for all releases of a branch, maxVersion should use * for compatibility ranges


(MailNews Core :: Build Config, enhancement)

Not set


(thunderbird12 fixed, thunderbird13 fixed, thunderbird-esr1012+ fixed)

Thunderbird 14.0
Tracking Status
thunderbird12 --- fixed
thunderbird13 --- fixed
thunderbird-esr10 12+ fixed


(Reporter: aryx, Assigned: standard8)




(Whiteboard: [esr])


(1 file, 1 obsolete file)

The language packs provided in the release folder on the ftp should work for all releases of a branch and not only a single release. With Enterprise Support Releases (ESR), this should provide more benefits (but also for normal users). At the moment, the language pack have the same minVersion and maxVersion, but because the strings are frozen, compatibility ranges should look like 10.0 - 10.0.* (This is being done for Thunderbird 3.1.x)
Ok, I'm moving this to core build config, as I suspect it affects everyone, although I also suspect we'll need different sets of fixes across the board.
Product: Thunderbird → Core
QA Contact: build-config → build-config
Version: unspecified → Trunk
Whiteboard: [esr]
Ok, Commandeering this back to Mailnews for the c-c part of what I'm going to be posting in bug 723135.
Assignee: nobody → mbanner
Depends on: 723135
Product: Core → MailNews Core
QA Contact: build-config → build-config
Attached patch The fix (obsolete) — Splinter Review
This is the c-c version of the fix from bug 723135.
Attachment #601022 - Flags: review?(bugspam.Callek)
Comment on attachment 601022 [details] [diff] [review]
The fix

I'm ok with this IFF the relevent m-c patch lands.

One caveat to note though is that chemspill releases will get a weird maxversion in the langpacks of, e.g. 11.0.1.* rather than 11.0.* with your code here
Attachment #601022 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 601022 [details] [diff] [review]
The fix

Damn, I meant to account for that. Gonna have to rethink that a little.
Attachment #601022 - Attachment is obsolete: true
Attached patch The fix v2Splinter Review
Ok, this matches the patch in bug 723135. I'm hoping to land this on Monday, so that we've got it in time for the various releases.
Attachment #614777 - Flags: review?(bugspam.Callek)
Attachment #614777 - Flags: review?(bugspam.Callek) → review+
Duplicate of this bug: 682816
Checked in:
Closed: 8 years ago
Resolution: --- → FIXED
This also required a bustage fix as bug 723135 hasn't landed yet:
Comment on attachment 614777 [details] [diff] [review]
The fix v2

[Triage Comment]
Moving forward across releases, as I want the test pilot fix for TB 12, and the langpack fixes for ESR.
Attachment #614777 - Flags: approval-comm-esr10+
Attachment #614777 - Flags: approval-comm-beta+
Attachment #614777 - Flags: approval-comm-aurora+
To be clear, I'm a bit surprised you self-approved and used your approval for the suite/* changes here.

That said, I would have approved for suite had it been asked, so no end-result harm done.
Sorry, I'd forgotten about the suite parts.
Target Milestone: --- → Thunderbird 14.0
You need to log in before you can comment on or make changes to this bug.