723222 - "Attach" keyword prompt should ignore reply text (attachment reminder's notification bar should not trigger on quoted text)

Status: RESOLVED DUPLICATE of bug 931774

(Thunderbird :: Message Compose Window, defect)

Description

[brian]

The prompt to attach a file when the word "attach" is in an outgoing message is a great feature. But please consider having the trigger ignore quoted text.

Consider the following scenario:
1. Receive an email from a colleague that says, "Please see the attached document." Document is attached.
2. Reply, "Thank you, that looks good."
3. Thunderbird asks you if you've forgotten to attach a document.
4. Click "No, I didn't."
5. Repeat 2-4 for a long thread.
6. Become annoyed and desensitized to the prompt.

As an alternative option, it could ignore text that's quoted more than one level deep.

Comment 1

[Hashem Masoud]

(In reply to brian from comment #0)
Which version are you using? I don't have this problem:
User Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0) Gecko/20120129 Thunderbird/10.0
Application Build ID: 20120129064000

Comment 2

[brian]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120129 Thunderbird/10.0
Build ID: 20120129183038

Comment 3

[Ludovic Hirlimann [:Usul]]

Brian does it also happens if you start Thunderbird with extension disabled ?

Comment 4

[brian]

Yup. I ran in safe mode, and it still happens.

Comment 5

[Magnus Melin [:mkmelin]]

Plain text or HTML compose mode? (Do the formatting controls show?)

Comment 6

[brian]

Ah. Only in plain text mode. There is no alert in HTML mode.

Comment 7

[Magnus Melin [:mkmelin]]

Seems to work fine over here.

FWIW, http://mxr.mozilla.org/comm-central/source/mail/components/compose/content/MsgComposeCommands.js#1490

Comment 8

[Ludovic Hirlimann [:Usul]]

Anything in Tools -> Error console ?

Comment 10

[Thomas D. (:thomas8)]

With one or two duplicates, I think we can say that this actually happens to users...

Comment 11

[:aceman]

Are you sure this still happens? There is code at http://mxr.mozilla.org/comm-central/source/mail/components/compose/content/MsgComposeCommands.js#1887 to specifically prevent looking into the quoted text. I do not see this problem, in plain text composition.

Can you provide proper steps to reproduce?

Comment 12

[Thomas D. (:thomas8)]

I know the general case is covered, but Bug 931774 Comment 2 asserts that edge cases like Bug 931774 still occur reliably. Aceman, can you try and reproduce bug 931774?

Also, Bug 871535 from 05-2013 reported against TB17 looks pretty recent. When was "ignore reply" introduced?

Comment 13

[Magnus Melin [:mkmelin]]

I'm pretty sure this is bug 931774, so duping.