723253 - Click to play/pause on video doesn't work after ESC pressed.

Status: RESOLVED WORKSFORME

(Toolkit :: Video/Audio Controls, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

STR:
1. Load a video, e.g. http://videos-cdn.mozilla.net/brand/Mozilla_Firefox_Manifesto_v0.2_640.webm
2. Click on the video to play the video.
3. Press ESC to stop the download. "Video Loading Stopped" text will appear over video, but video will keep playing.
4. Click on the video to stop video playback, but it doesn't work!

Expected Result:
* Clicking on a video whose load has stopped should still toggle play/pause.

Comment 1

[Alice0775 White]

Regression window
Works:
http://hg.mozilla.org/mozilla-central/rev/fafaf614791f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111206 Firefox/11.0a1 ID:20111206031117
Fails:
http://hg.mozilla.org/mozilla-central/rev/338fae43b9d0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111205 Firefox/11.0a1 ID:20111205235717
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=fafaf614791f&tochange=338fae43b9d0

Suspected; Bug 513405

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

This looks just like bug 723097.

Chris: Are you running Windows 7 as the bug states? Mihaela mentioned that bug 723097 was only reproducible on Windows XP.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Yes I'm running Win7.

The only way I can reproduce bug 723097 is when the video is fully stored in the network cache, and so the video loads instantly. So pressing ESC isn't stopping autoplay in that case; which is what I think Mihaela is complaining about. I don't actually think we want to force playback to stop in that case, we just want to force network activity to stop.

Whereas here I'm saying that if you play and then press ESC before the video is fully loaded, you can't stop playback.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

We no longer stop loading the video when Esc is pressed. With that being said, hitting Esc while the video is loading and then trying to play/pause does allow me to play/pause on Windows 10 Nightly 2016-05-04.