Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Fix failing test layout/reftests/transform-3d/preserve3d-1a.html

RESOLVED FIXED in mozilla13

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: ayg, Assigned: ayg)

Tracking

(Depends on: 1 bug)

Trunk
mozilla13
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

layout/reftests/transform-3d/preserve3d-1a.html was introduced by bug 505115, part 13.  It was checked in as "fails".  This is because the test file does four 90deg rotations, which means a full circle, while the ref file does a 180deg rotation.  Changing the test file to do 45deg rotations instead makes the test pass.  Patch to be attached in a moment.
Created attachment 593948 [details] [diff] [review]
Patch

If I apply the change to reftest.list and run reftests in this directory, I get a new fail.  When I then apply the change to preserve3d-1a.html, the newly-enabled test passes.
Assignee: nobody → ayg
Attachment #593948 - Flags: review?(roc)
Attachment #593948 - Flags: review?(roc) → review?(matt.woodrow)
Attachment #593948 - Flags: review?(matt.woodrow) → review+
Keywords: checkin-needed

Updated

6 years ago
Whiteboard: [autoland-try]

Updated

6 years ago
Whiteboard: [autoland-try] → [autoland-in-queue]

Comment 2

6 years ago
Autoland Patchset:
	Patches: 593948
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/b10bdff08543
Try run started, revision b10bdff08543. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=b10bdff08543

Comment 3

6 years ago
Try run for b10bdff08543 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=b10bdff08543
Results (out of 207 total builds):
    success: 181
    warnings: 26
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-b10bdff08543

Updated

6 years ago
Whiteboard: [autoland-in-queue]

Comment 4

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d683e5c2082
Flags: in-testsuite+
Keywords: checkin-needed
Target Milestone: --- → mozilla13
Unfortunately, the test still fails on Windows:

https://tbpl.mozilla.org/php/getParsedLog.php?id=9083374&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=9083607&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=9083078&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=9083277&tree=Mozilla-Inbound
Flags: in-testsuite+
Target Milestone: mozilla13 → ---

Comment 6

6 years ago
Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/240903c32a9b
So it seems to need fails-if(/^Windows\x20NT\x206\.1/.test(http.oscpu)).
Created attachment 595152 [details] [diff] [review]
Patch v2

Same patch with the incantation from comment 7.
Attachment #593948 - Attachment is obsolete: true
Comment on attachment 595152 [details] [diff] [review]
Patch v2

Re-requesting review.  I'll try autoland this time, but I can't do that yet until I have r+ from someone with commit access.
Attachment #595152 - Flags: review?(roc)
Attachment #595152 - Flags: review?(roc) → review+
Whiteboard: [autoland]

Updated

6 years ago
Whiteboard: [autoland] → [autoland-in-queue]

Comment 10

6 years ago
Autoland Patchset:
	Patches: 595152
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/bdc880c761e0
Try run started, revision bdc880c761e0. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=bdc880c761e0

Comment 11

6 years ago
Try run for bdc880c761e0 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=bdc880c761e0
Results (out of 210 total builds):
    success: 189
    warnings: 21
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-bdc880c761e0
 Timed out after 06 hours without completing.

Updated

6 years ago
Whiteboard: [autoland-in-queue]
Looks good enough
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/0c1b517c9907
Keywords: checkin-needed
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/0c1b517c9907
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Depends on: 730750
Depends on: 735866
You need to log in before you can comment on or make changes to this bug.