723680 - Fix failing test layout/reftests/transform-3d/preserve3d-1a.html

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

layout/reftests/transform-3d/preserve3d-1a.html was introduced by bug 505115, part 13.  It was checked in as "fails".  This is because the test file does four 90deg rotations, which means a full circle, while the ref file does a 180deg rotation.  Changing the test file to do 45deg rotations instead makes the test pass.  Patch to be attached in a moment.

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Patch

If I apply the change to reftest.list and run reftests in this directory, I get a new fail.  When I then apply the change to preserve3d-1a.html, the newly-enabled test passes.

Comment 2

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 593948
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/b10bdff08543
Try run started, revision b10bdff08543. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=b10bdff08543

Comment 3

[Mozilla RelEng Bot]

Try run for b10bdff08543 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=b10bdff08543
Results (out of 207 total builds):
    success: 181
    warnings: 26
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-b10bdff08543

Comment 4

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d683e5c2082

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Unfortunately, the test still fails on Windows:

https://tbpl.mozilla.org/php/getParsedLog.php?id=9083374&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=9083607&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=9083078&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=9083277&tree=Mozilla-Inbound

Comment 6

[Ed Morley [:emorley]]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/240903c32a9b

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

So it seems to need fails-if(/^Windows\x20NT\x206\.1/.test(http.oscpu)).

Comment 8

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Patch v2

Same patch with the incantation from comment 7.

Comment 9

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Comment on attachment 595152 [details] [diff] [review]
Patch v2

Re-requesting review.  I'll try autoland this time, but I can't do that yet until I have r+ from someone with commit access.

Comment 10

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 595152
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/bdc880c761e0
Try run started, revision bdc880c761e0. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=bdc880c761e0

Comment 11

[Mozilla RelEng Bot]

Try run for bdc880c761e0 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=bdc880c761e0
Results (out of 210 total builds):
    success: 189
    warnings: 21
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-bdc880c761e0
 Timed out after 06 hours without completing.

Comment 12

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Looks good enough

Comment 13

[Dão Gottwald [::dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/0c1b517c9907

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0c1b517c9907