Last Comment Bug 723680 - Fix failing test layout/reftests/transform-3d/preserve3d-1a.html
: Fix failing test layout/reftests/transform-3d/preserve3d-1a.html
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: CSS Parsing and Computation (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla13
Assigned To: Aryeh Gregor (:ayg) (away until October 25)
:
:
Mentors:
Depends on: 735866 730750
Blocks: 505115
  Show dependency treegraph
 
Reported: 2012-02-02 12:49 PST by Aryeh Gregor (:ayg) (away until October 25)
Modified: 2012-03-14 14:44 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (2.35 KB, patch)
2012-02-02 12:51 PST, Aryeh Gregor (:ayg) (away until October 25)
roc: review+
Details | Diff | Splinter Review
Patch v2 (2.40 KB, patch)
2012-02-07 13:31 PST, Aryeh Gregor (:ayg) (away until October 25)
roc: review+
Details | Diff | Splinter Review

Description Aryeh Gregor (:ayg) (away until October 25) 2012-02-02 12:49:43 PST
layout/reftests/transform-3d/preserve3d-1a.html was introduced by bug 505115, part 13.  It was checked in as "fails".  This is because the test file does four 90deg rotations, which means a full circle, while the ref file does a 180deg rotation.  Changing the test file to do 45deg rotations instead makes the test pass.  Patch to be attached in a moment.
Comment 1 Aryeh Gregor (:ayg) (away until October 25) 2012-02-02 12:51:38 PST
Created attachment 593948 [details] [diff] [review]
Patch

If I apply the change to reftest.list and run reftests in this directory, I get a new fail.  When I then apply the change to preserve3d-1a.html, the newly-enabled test passes.
Comment 2 Mozilla RelEng Bot 2012-02-03 15:07:32 PST
Autoland Patchset:
	Patches: 593948
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/b10bdff08543
Try run started, revision b10bdff08543. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=b10bdff08543
Comment 3 Mozilla RelEng Bot 2012-02-03 20:45:26 PST
Try run for b10bdff08543 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=b10bdff08543
Results (out of 207 total builds):
    success: 181
    warnings: 26
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-b10bdff08543
Comment 4 Boris Zbarsky [:bz] (still a bit busy) 2012-02-03 21:02:38 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d683e5c2082
Comment 6 Ed Morley [:emorley] 2012-02-04 04:07:00 PST
Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/240903c32a9b
Comment 7 :Ms2ger (⌚ UTC+1/+2) 2012-02-07 09:16:04 PST
So it seems to need fails-if(/^Windows\x20NT\x206\.1/.test(http.oscpu)).
Comment 8 Aryeh Gregor (:ayg) (away until October 25) 2012-02-07 13:31:40 PST
Created attachment 595152 [details] [diff] [review]
Patch v2

Same patch with the incantation from comment 7.
Comment 9 Aryeh Gregor (:ayg) (away until October 25) 2012-02-07 13:32:58 PST
Comment on attachment 595152 [details] [diff] [review]
Patch v2

Re-requesting review.  I'll try autoland this time, but I can't do that yet until I have r+ from someone with commit access.
Comment 10 Mozilla RelEng Bot 2012-02-07 18:24:40 PST
Autoland Patchset:
	Patches: 595152
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/bdc880c761e0
Try run started, revision bdc880c761e0. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=bdc880c761e0
Comment 11 Mozilla RelEng Bot 2012-02-08 04:00:25 PST
Try run for bdc880c761e0 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=bdc880c761e0
Results (out of 210 total builds):
    success: 189
    warnings: 21
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-bdc880c761e0
 Timed out after 06 hours without completing.
Comment 12 :Ms2ger (⌚ UTC+1/+2) 2012-02-08 07:59:49 PST
Looks good enough
Comment 14 Ed Morley [:emorley] 2012-02-09 10:15:43 PST
https://hg.mozilla.org/mozilla-central/rev/0c1b517c9907

Note You need to log in before you can comment on or make changes to this bug.