723772 - regression: Panning in XUL fennec does not start until finger is removed from screen.

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Matt Brubeck (:mbrubeck)]

Note: This is in a build of mozilla-central tip plus the patch from bug 723480.  (Without that patch, panning doesn't work at all.)

Steps to reproduce:
1) Drag to scroll any part of chrome or content in XUL Fennec.

Expected results: Scrolling happens as you move your finger.
Actual results: Nothing happens while you drag.  Scrolling happens after you lift your finger.

It looks like mouse events aren't sent until a touch is finished.  Possibly a regression from bug 721484.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

This fixes the bug for me.  Next I'll test to make sure it doesn't regress anything in native Fennec.

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 594033 [details] [diff] [review]
patch

Review of attachment 594033 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with a little change. Thanks for finding this matt!

::: widget/android/nsWindow.cpp
@@ -1586,3 @@
>      }
>      return false;
>  }

We can just remove this return and instead return preventPanning at the end.

Comment 3

[Matt Brubeck (:mbrubeck)]

Pushed with review comment addressed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d1a7abd2991

QA note: It won't be possible to verify this fix until bug 723480 is fixed.

Comment 4

[Matt Brubeck (:mbrubeck)]

Comment on attachment 594033 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): bug 721484

User impact if declined: Panning is badly broken in XUL fennec.

Testing completed (on m-c, etc.): Landed on inbound 2/2.

Risk to taking this patch (and alternatives if risky): This is a low-risk Android-only trivial fix for some broken code.

String changes made by this patch: None.

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9d1a7abd2991

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 594033 [details] [diff] [review]
patch

[Triage Comment]
Approved for Aurora 12 and Beta 11.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e222d18ba92c

Comment 8

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/releases/mozilla-beta/rev/4582aedd2320