Closed Bug 723480 Opened 8 years ago Closed 8 years ago

Single touch broken in Feb 1 2012 XUL Nightly

Categories

(Firefox for Android Graveyard :: General, defect, critical)

Firefox 12
defect
Not set
critical

Tracking

(firefox11 fixed, firefox12 fixed, firefox13 fixed, fennec11+)

VERIFIED FIXED
Firefox 13
Tracking Status
firefox11 --- fixed
firefox12 --- fixed
firefox13 --- fixed
fennec 11+ ---

People

(Reporter: kairo, Assigned: mbrubeck)

References

Details

(Keywords: regression)

Attachments

(1 file)

I just downloaded the XUL Nightly of Feb 1 (first with 13.0a1, but no real code changes in there yet from what I see) to my tablet and discovered that all single-touch actions (clicking links, trying to access tabs, trying to focus the awesomebar or open the menu) are broken. Two-finger pinch zoom works, though.

When I got the last 12.0a1 Nightly from Jan 31, this works fine, so the regression is within this one day of m-c. Given that practically no change landed on m-c between the Aurora uplift and the point where the Feb 1 Nightly was cut, I'd expect this problem to exist on Aurora 12 as well, but I haven't tested yet.
OK, this is indeed affecting Aurora 12 XUL as well. As this might very well end up shipping on tablets, nominating for tracking.

Also, this means that bug 723200 has no influence on this, as it happens before this landed. And bug 603008 already landed way before the 12.0a1 build from Jan 31 that still works.
Given the two Nightly builds I tested and looking at their changesets, the regression range would be:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3f26b7bee352&tochange=e18c7bc2c28e

As I tested that this is on today's Aurora 12 as well, we can ignore whatever came after the uplift, so that reduces the regression range to this:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3f26b7bee352&tochange=AURORA_BASE_20120131
Duplicate of this bug: 723450
Assignee: nobody → mbrubeck
tracking-fennec: --- → ?
The first bad revision is:
https://hg.mozilla.org/mozilla-central/rev/2fa163bb05d7
Wes Johnston <wjohnston@mozilla.com>
Bug 721484 - Don't disable mouse events for touch events. r=blassey
Blocks: 721484
Version: Trunk → Firefox 12
Attached patch patchSplinter Review
This fixes the bug for me.
Attachment #594018 - Flags: review?(wjohnston)
Comment on attachment 594018 [details] [diff] [review]
patch

Review of attachment 594018 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not very comfortable reviewing this (I've messed this up twice now because I don't understand how these defines trickle around). Blassey?
Attachment #594018 - Flags: review?(wjohnston) → review?(blassey.bugs)
Blocks: 723772
Attachment #594018 - Flags: review?(blassey.bugs) → review+
(In reply to Matt Brubeck (:mbrubeck) from comment #5)
> Created attachment 594018 [details] [diff] [review]

Well not exactly perfect.  I can verify that this patch fixes the issue reported here.  However, we end up back with the issue reported in bug 721484.
(In reply to Bill Gianopoulos [:WG9s] from comment #7)
> (In reply to Matt Brubeck (:mbrubeck) from comment #5)
> > Created attachment 594018 [details] [diff] [review]
> 
> Well not exactly perfect.  I can verify that this patch fixes the issue
> reported here.  However, we end up back with the issue reported in bug
> 721484.

That said, from looking at config.status it appears this patch should have worked correctly in both cases.  Perhaps something else broke the testcase in bug 721484.  I am redoing my native feeenc build with this backed out to see what happens.
(In reply to Bill Gianopoulos [:WG9s] from comment #8)
> (In reply to Bill Gianopoulos [:WG9s] from comment #7)
> > (In reply to Matt Brubeck (:mbrubeck) from comment #5)
> > > Created attachment 594018 [details] [diff] [review]
> > 
> > Well not exactly perfect.  I can verify that this patch fixes the issue
> > reported here.  However, we end up back with the issue reported in bug
> > 721484.
> 
> That said, from looking at config.status it appears this patch should have
> worked correctly in both cases.  Perhaps something else broke the testcase
> in bug 721484.  I am redoing my native feeenc build with this backed out to
> see what happens.

Never mind.  I can't get that testcase to work in today's nightly Android native build either, which does not include this patch.  Must be a different issue.  Go figure ;-)
https://hg.mozilla.org/mozilla-central/rev/cadfebcc626e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Comment on attachment 594018 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): bug 721484

User impact if declined: XUL Fennec completely broken (does not respond to touch input).

Testing completed (on m-c, etc.): Tested locally by myself, wesj, and WG9s; landed on m-c February 3.

Risk to taking this patch (and alternatives if risky): Low risk.  This is a trivial fix to a build system bug that caused some code to be accidentally enabled in XUL Fennec when it never should have been.  This is effectively a partial backout of an accidental change.

String changes made by this patch: None.
Attachment #594018 - Flags: approval-mozilla-beta?
Attachment #594018 - Flags: approval-mozilla-aurora?
As the reporter, I think marking this as verified is OK - I can confirm that today's 13.0a1 XUL Nightly works on my TF101. Thanks for the fix!
Status: RESOLVED → VERIFIED
Comment on attachment 594018 [details] [diff] [review]
patch

[Triage Comment]
Important fix - approved for Aurora 12 and Beta 11.
Attachment #594018 - Flags: approval-mozilla-beta?
Attachment #594018 - Flags: approval-mozilla-beta+
Attachment #594018 - Flags: approval-mozilla-aurora?
Attachment #594018 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.