Last Comment Bug 723832 - New Tab Page frequently leaks 4-700+Kb (AtomImpl + BackstagePass + DOMCSSDeclarationImpl + DOMCSSStyleRule + more) in mochitest-browser-chrome
: New Tab Page frequently leaks 4-700+Kb (AtomImpl + BackstagePass + DOMCSSDecl...
Status: RESOLVED DUPLICATE of bug 750424
[MemShrink:P1]
: intermittent-failure, mlk, regression
Product: Firefox
Classification: Client Software
Component: Tabbed Browser (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on: 723102 738167
Blocks: 438871 716538
  Show dependency treegraph
 
Reported: 2012-02-02 22:13 PST by Phil Ringnalda (:philor)
Modified: 2013-12-17 08:53 PST (History)
11 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
-
affected
-
affected


Attachments

Description Phil Ringnalda (:philor) 2012-02-02 22:13:24 PST
This leak exploded this morning on mozilla-inbound, and I wanted to pin it on the push after a merge from mozilla-central, because the merge was green and the next push had three instances of this leak, but I didn't have time during the day, and then bugmail about this same leak being misstarred as a crashtest leak alerted me that it was on mozilla-central before my blame-target had gotten there.

First seen on mozilla-central on https://hg.mozilla.org/mozilla-central/rev/1cdef0321abd (merge from fx-team), first seen on fx-team on https://hg.mozilla.org/integration/fx-team/rev/29c4463e6a2e (enable New Tab Page and what I presume are supporters, which are just as likely to be the real cause I suppose).

Retriggers in https://tbpl.mozilla.org/?tree=Fx-Team&rev=29c4463e6a2e show plenty more instances beside the one that was there from the initial push; retriggers on the parent in https://tbpl.mozilla.org/?tree=Fx-Team&rev=e7f7c1e948ca don't show any (gambling, because I still have a couple of retriggers running right this second, but the odds are with me).

Sorry, but, j'accuse.

http://tbpl.swatinem.de/php/getLeakAnalysis.php?id=9053424 (the working version of the "analyze the leak" links that are broken on tbpl.m.o) only mentions the lying not actually leaked domwindow from test_process_error.xul, so unfortunately there's no help about which test is triggering the leak, other than "something in browser-chrome" (and "not test_process_error.xul, which isn't even in browser-chrome").
Comment 13 Tim Taubert [:ttaubert] (on PTO, back Aug 29th) 2012-02-04 02:21:16 PST
I'm optimistic about this being fixed by bug 723102 - we accidentally hold New Tab Pages alive by the JSM (instead of properly unregistering them). Will land today.
Comment 27 Tim Taubert [:ttaubert] (on PTO, back Aug 29th) 2012-02-08 02:59:55 PST
Marking as fixed by bug 723102.
Comment 28 Phil Ringnalda (:philor) 2012-02-09 21:55:17 PST
https://tbpl.mozilla.org/php/getParsedLog.php?id=9230791&tree=Mozilla-Aurora (a couple of pushes after you flipped the pref on aurora) reminds me a great deal of this, so I think you might have had another thing involved in the leak fix, that didn't hit aurora.
Comment 37 Tim Taubert [:ttaubert] (on PTO, back Aug 29th) 2012-02-15 05:14:37 PST
https://tbpl.mozilla.org/php/getParsedLog.php?id=9354191&tree=Mozilla-Aurora
Comment 38 Tim Taubert [:ttaubert] (on PTO, back Aug 29th) 2012-02-15 05:15:26 PST
(In reply to Phil Ringnalda (:philor) from comment #28)
> https://tbpl.mozilla.org/php/getParsedLog.php?id=9230791&tree=Mozilla-Aurora
> (a couple of pushes after you flipped the pref on aurora) reminds me a great
> deal of this, so I think you might have had another thing involved in the
> leak fix, that didn't hit aurora.

Yeah, but I don't have a clue what changeset fixed that entirely. Need to look what landed around the same time.
Comment 42 Phil Ringnalda (:philor) 2012-03-14 22:33:27 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=10084544&tree=Mozilla-Inbound

Sure was nice having this gone for a while, back when it was gone for a while.
Comment 50 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-03-16 14:48:02 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=10131089&tree=Firefox&full=1
Comment 60 Andrew McCreight [:mccr8] 2012-03-21 16:35:34 PDT
Nominating for tracking because it is a fairly large, fairly frequent leak apparently introduced by a new feature.
Comment 68 Alex Keybl [:akeybl] 2012-03-26 15:47:48 PDT
(In reply to Andrew McCreight [:mccr8] from comment #60)
> Nominating for tracking because it is a fairly large, fairly frequent leak
> apparently introduced by a new feature.

This is reasonable - also sending over to Tim since we suspect this to be related to the new tab page.
Comment 72 Tim Taubert [:ttaubert] (on PTO, back Aug 29th) 2012-03-27 06:12:12 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=10402559&tree=Fx-Team
Comment 74 Tim Taubert [:ttaubert] (on PTO, back Aug 29th) 2012-03-28 03:04:08 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=10433012&tree=Fx-Team
Comment 79 Tim Taubert [:ttaubert] (on PTO, back Aug 29th) 2012-03-29 06:14:47 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=10471032&tree=Fx-Team
Comment 85 Tim Taubert [:ttaubert] (on PTO, back Aug 29th) 2012-03-30 03:09:31 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=10488963&tree=Fx-Team
Comment 86 Tim Taubert [:ttaubert] (on PTO, back Aug 29th) 2012-03-30 08:14:12 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=10502922&tree=Fx-Team
Comment 99 Tim Taubert [:ttaubert] (on PTO, back Aug 29th) 2012-04-05 19:34:34 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=10683992&tree=Fx-Team
Comment 112 Tim Taubert [:ttaubert] (on PTO, back Aug 29th) 2012-04-11 15:59:10 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=10824216&tree=Fx-Team
Comment 115 Tim Taubert [:ttaubert] (on PTO, back Aug 29th) 2012-04-13 07:40:54 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=10874891&tree=Fx-Team
Comment 117 Tim Taubert [:ttaubert] (on PTO, back Aug 29th) 2012-04-13 18:13:40 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=10893556&tree=Fx-Team
Comment 121 Nicholas Nethercote [:njn] 2012-04-15 23:01:34 PDT
What's happening here?  This is a significant leak in a new feature.
Comment 141 Tim Taubert [:ttaubert] (on PTO, back Aug 29th) 2012-04-27 03:50:42 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=11242795&tree=Fx-Team
Comment 149 Alex Keybl [:akeybl] 2012-05-02 15:18:08 PDT
(In reply to Tim Taubert [:ttaubert] from comment #38)
> (In reply to Phil Ringnalda (:philor) from comment #28)
> > https://tbpl.mozilla.org/php/getParsedLog.php?id=9230791&tree=Mozilla-Aurora
> > (a couple of pushes after you flipped the pref on aurora) reminds me a great
> > deal of this, so I think you might have had another thing involved in the
> > leak fix, that didn't hit aurora.
> 
> Yeah, but I don't have a clue what changeset fixed that entirely. Need to
> look what landed around the same time.

This appears to still be a problem on FF13 and up. What are the next steps for this investigation?
Comment 150 Bill McCloskey (:billm) 2012-05-02 15:42:23 PDT
I'm kind of hoping that this was fixed by bug 750424. It hasn't happened on inbound since that patch landed, but with the tree closed there haven't been enough pushes to say for sure.
Comment 152 Bill McCloskey (:billm) 2012-05-04 10:36:23 PDT
I'm going to call this fixed.

*** This bug has been marked as a duplicate of bug 750424 ***
Comment 156 Alex Keybl [:akeybl] 2012-05-14 09:04:52 PDT
(In reply to Bill McCloskey (:billm) from comment #150)
> I'm kind of hoping that this was fixed by bug 750424. It hasn't happened on
> inbound since that patch landed, but with the tree closed there haven't been
> enough pushes to say for sure.

We'll track bug 750424 instead in that case. Thanks!

Note You need to log in before you can comment on or make changes to this bug.