723908 - Dark toolbars use wrong text colour on Linux

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Chris Coulson]

Attachment: Use -moz-menubartext rather than MenuText for text on menubar styled elements

Design have changed our dark theme in Ubuntu to have light coloured menu popups with dark text (rather than dark popups with light text, like we had previously). Unfortunately, this exposes a bug in the Thunderbird theme, which styles the tabs in the main window and the toolbars in the compose / addressbook windows with the background of the menubar (which is dark), and the text colour of the menu popups (which used to be light, but is now dark).

It seems that Thunderbird should be using -moz-menubartext rather than MenuText in these cases (Firefox seems to do this already, so it didn't break with our theme change)

Comment 1

[Andreas Nilsson (:andreasn)]

Comment on attachment 594152 [details] [diff] [review]
Use -moz-menubartext rather than MenuText for text on menubar styled elements

MDN says "-moz-menubartext - Foreground color for text in menu bars.  Often similar to MenuText.  Should be used on top of Menu background."
So that should be all right here.

Looks good on Light themes (Clearlooks on Fedora) and Dark themes (Ambiance on Ubuntu [2])

1. https://developer.mozilla.org/en/CSS/color_value#Mozilla_System_Color_Extensions
2. http://ubuntuone.com/5rS8S6dIb2LgVlAuC0sJzV

Comment 2

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/comm-central/rev/a1dbe0bb4266

To make life easier for those checking in patches for you, please follow the instructions below in your future patches. Thanks!
https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F