Last Comment Bug 723908 - Dark toolbars use wrong text colour on Linux
: Dark toolbars use wrong text colour on Linux
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: Thunderbird 13.0
Assigned To: Chris Coulson
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-03 06:13 PST by Chris Coulson
Modified: 2012-03-02 14:21 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Use -moz-menubartext rather than MenuText for text on menubar styled elements (1.48 KB, patch)
2012-02-03 06:13 PST, Chris Coulson
bugs: review+
bugs: ui‑review+
Details | Diff | Review

Description Chris Coulson 2012-02-03 06:13:01 PST
Created attachment 594152 [details] [diff] [review]
Use -moz-menubartext rather than MenuText for text on menubar styled elements

Design have changed our dark theme in Ubuntu to have light coloured menu popups with dark text (rather than dark popups with light text, like we had previously). Unfortunately, this exposes a bug in the Thunderbird theme, which styles the tabs in the main window and the toolbars in the compose / addressbook windows with the background of the menubar (which is dark), and the text colour of the menu popups (which used to be light, but is now dark).

It seems that Thunderbird should be using -moz-menubartext rather than MenuText in these cases (Firefox seems to do this already, so it didn't break with our theme change)
Comment 1 Andreas Nilsson (:andreasn) 2012-03-02 06:47:08 PST
Comment on attachment 594152 [details] [diff] [review]
Use -moz-menubartext rather than MenuText for text on menubar styled elements

MDN says "-moz-menubartext - Foreground color for text in menu bars.  Often similar to MenuText.  Should be used on top of Menu background."
So that should be all right here.

Looks good on Light themes (Clearlooks on Fedora) and Dark themes (Ambiance on Ubuntu [2])

1. https://developer.mozilla.org/en/CSS/color_value#Mozilla_System_Color_Extensions
2. http://ubuntuone.com/5rS8S6dIb2LgVlAuC0sJzV
Comment 2 Ryan VanderMeulen [:RyanVM] 2012-03-02 14:21:29 PST
http://hg.mozilla.org/comm-central/rev/a1dbe0bb4266

To make life easier for those checking in patches for you, please follow the instructions below in your future patches. Thanks!
https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Note You need to log in before you can comment on or make changes to this bug.