Closed Bug 723924 Opened 8 years ago Closed 8 years ago

Telemetry for time needed for single frecency update and updates count

Categories

(Toolkit :: Places, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: mak, Assigned: mak)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

We don't have a precise idea of how much frecency updates do hurt, would be nice to know.
Blocks: 671038
Attached patch patch v1.0 (obsolete) — Splinter Review
The results I get are pretty fast and lower than 1ms, though in the wild we may see something more interesting
Attachment #594751 - Flags: review?(dietrich)
Attached patch patch v1.1Splinter Review
reduced the buckets from 10-200 to 1-100
Attachment #594751 - Attachment is obsolete: true
Attachment #594751 - Flags: review?(dietrich)
Attachment #594752 - Flags: review?(dietrich)
Comment on attachment 594752 [details] [diff] [review]
patch v1.1

Review of attachment 594752 [details] [diff] [review]:
-----------------------------------------------------------------

i'm worried that we won't find out how bad the problem can be with such a low max bucket. however, anything over a certain point might just be contention. maybe bump to 500?
Attachment #594752 - Flags: review?(dietrich) → review+
(In reply to Dietrich Ayala (:dietrich) from comment #3)
> Comment on attachment 594752 [details] [diff] [review]
> patch v1.1
> 
> Review of attachment 594752 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> i'm worried that we won't find out how bad the problem can be with such a
> low max bucket. however, anything over a certain point might just be
> contention. maybe bump to 500?

most of the measures I saw are around 0-1ms, anything above 50ms would be really bad regardless how much bad they are.
https://hg.mozilla.org/integration/mozilla-inbound/rev/997e5fc79574
Flags: in-testsuite+
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/997e5fc79574
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.