Closed
Bug 723924
Opened 14 years ago
Closed 14 years ago
Telemetry for time needed for single frecency update and updates count
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: mak, Assigned: mak)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
4.78 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
We don't have a precise idea of how much frecency updates do hurt, would be nice to know.
|
Assignee | |
Comment 1•14 years ago
|
||
The results I get are pretty fast and lower than 1ms, though in the wild we may see something more interesting
Attachment #594751 -
Flags: review?(dietrich)
|
|
Assignee | |
Comment 2•14 years ago
|
||
reduced the buckets from 10-200 to 1-100
Attachment #594751 -
Attachment is obsolete: true
Attachment #594751 -
Flags: review?(dietrich)
Attachment #594752 -
Flags: review?(dietrich)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 594752 [details] [diff] [review]
patch v1.1
Review of attachment 594752 [details] [diff] [review]:
-----------------------------------------------------------------
i'm worried that we won't find out how bad the problem can be with such a low max bucket. however, anything over a certain point might just be contention. maybe bump to 500?
Attachment #594752 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
(In reply to Dietrich Ayala (:dietrich) from comment #3)
> Comment on attachment 594752 [details] [diff] [review]
> patch v1.1
>
> Review of attachment 594752 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> i'm worried that we won't find out how bad the problem can be with such a
> low max bucket. however, anything over a certain point might just be
> contention. maybe bump to 500?
most of the measures I saw are around 0-1ms, anything above 50ms would be really bad regardless how much bad they are.
|
|
Assignee | |
Comment 5•14 years ago
|
||
Flags: in-testsuite+
Target Milestone: --- → mozilla13
|
|
Assignee | |
Comment 6•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•