Closed
Bug 724042
Opened 12 years ago
Closed 12 years ago
disable tile by tile rendering
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 724230
People
(Reporter: blassey, Unassigned)
Details
(Whiteboard: not-fennec-11)
Attachments
(1 file)
6.59 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #594245 -
Flags: review?(doug.turner)
Comment 1•12 years ago
|
||
Comment on attachment 594245 [details] [diff] [review] patch This patch unnecessarily allocates a big-ass buffer when using gralloc.
Comment 2•12 years ago
|
||
(In reply to Kartikaya Gupta (:kats) from comment #1) > Comment on attachment 594245 [details] [diff] [review] > patch > > This patch unnecessarily allocates a big-ass buffer when using gralloc. Oh, never mind. Misread the patch.
Comment 3•12 years ago
|
||
Comment on attachment 594245 [details] [diff] [review] patch Review of attachment 594245 [details] [diff] [review]: ----------------------------------------------------------------- this is fine to get us going. good to have chris take another look post uplifting. ::: mobile/android/base/gfx/GeckoSoftwareLayerClient.java @@ +239,3 @@ > mBufferSize = new IntSize(width, height); > + if (mTileLayer instanceof SingleTileLayer) { > + int size = mBufferSize.getArea() * 2; why * 2? @@ +286,4 @@ > // Reallocate the buffer if necessary > + if (mTileLayer instanceof SingleTileLayer) { > + // * 2 because it's a 16-bit buffer (so 2 bytes per pixel). > + size = mBufferSize.getArea() * 2; is it always * 2?
Attachment #594245 -
Flags: review?(doug.turner) → review+
Reporter | ||
Comment 4•12 years ago
|
||
(In reply to Doug Turner (:dougt) from comment #3) > Comment on attachment 594245 [details] [diff] [review] > patch > > Review of attachment 594245 [details] [diff] [review]: > ----------------------------------------------------------------- > > this is fine to get us going. good to have chris take another look post > uplifting. > > ::: mobile/android/base/gfx/GeckoSoftwareLayerClient.java > @@ +239,3 @@ > > mBufferSize = new IntSize(width, height); > > + if (mTileLayer instanceof SingleTileLayer) { > > + int size = mBufferSize.getArea() * 2; > > why * 2? > > @@ +286,4 @@ > > // Reallocate the buffer if necessary > > + if (mTileLayer instanceof SingleTileLayer) { > > + // * 2 because it's a 16-bit buffer (so 2 bytes per pixel). > > + size = mBufferSize.getArea() * 2; > > is it always * 2? yes, its always 2.
Reporter | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/663892ff23e0
Whiteboard: [inbound]
Comment 6•12 years ago
|
||
Backed out in inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/9415c0c24d53 since Chris put up a more comprehensive patch in bug 724230 that we should use instead.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
Whiteboard: [inbound]
Updated•12 years ago
|
Whiteboard: not-fennec-11
Assignee | ||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•