724042 - disable tile by tile rendering

Status: RESOLVED DUPLICATE of bug 724230

(Firefox for Android Graveyard :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 594245 [details] [diff] [review]
patch

This patch unnecessarily allocates a big-ass buffer when using gralloc.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

(In reply to Kartikaya Gupta (:kats) from comment #1)
> Comment on attachment 594245 [details] [diff] [review]
> patch
> 
> This patch unnecessarily allocates a big-ass buffer when using gralloc.

Oh, never mind. Misread the patch.

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 594245 [details] [diff] [review]
patch

Review of attachment 594245 [details] [diff] [review]:
-----------------------------------------------------------------

this is fine to get us going.  good to have chris take another look post uplifting.

::: mobile/android/base/gfx/GeckoSoftwareLayerClient.java
@@ +239,3 @@
>                  mBufferSize = new IntSize(width, height);
> +                if (mTileLayer instanceof SingleTileLayer) {
> +                    int size = mBufferSize.getArea() * 2;

why * 2?

@@ +286,4 @@
>              // Reallocate the buffer if necessary
> +            if (mTileLayer instanceof SingleTileLayer) {
> +                // * 2 because it's a 16-bit buffer (so 2 bytes per pixel).
> +                size = mBufferSize.getArea() * 2;

is it always * 2?

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Doug Turner (:dougt) from comment #3)
> Comment on attachment 594245 [details] [diff] [review]
> patch
> 
> Review of attachment 594245 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> this is fine to get us going.  good to have chris take another look post
> uplifting.
> 
> ::: mobile/android/base/gfx/GeckoSoftwareLayerClient.java
> @@ +239,3 @@
> >                  mBufferSize = new IntSize(width, height);
> > +                if (mTileLayer instanceof SingleTileLayer) {
> > +                    int size = mBufferSize.getArea() * 2;
> 
> why * 2?
> 
> @@ +286,4 @@
> >              // Reallocate the buffer if necessary
> > +            if (mTileLayer instanceof SingleTileLayer) {
> > +                // * 2 because it's a 16-bit buffer (so 2 bytes per pixel).
> > +                size = mBufferSize.getArea() * 2;
> 
> is it always * 2?

yes, its always 2.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/663892ff23e0

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Backed out in inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/9415c0c24d53

since Chris put up a more comprehensive patch in bug 724230 that we should use instead.