On-demand tile patches are risky and unnecessary without further patches/testing

RESOLVED FIXED in Firefox 12

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cwiiis, Assigned: cwiiis)

Tracking

12 Branch
Firefox 13
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 unaffected, firefox12 fixed, firefox13 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
The patch in bug #717283 was checked in to enable other optimisations, but none of these optimisations are ready yet. On its own, this patch is possibly a slight performance decrease, and introduces unnecessary risk.

We should back it out until we're ready.

Unfortunately, other work was done inside this patch and on top of it, so the back-out patch is not entirely trivial. Patch incoming.
(Assignee)

Comment 1

5 years ago
Created attachment 594418 [details] [diff] [review]
Backout ondemand tiling

This patch backs out on-demand tiling, but doesn't back out any of the other associated work/fixes (some initialisation memory leak fixes, checkerboard metrics)

I'm currently at FOSDEM and won't be back until Monday evening, so if this needs checking in before Tuesday morning GMT, someone else needs to do it.

I've marked both dougt and blassey as reviewers, but I only think it needs the one review, so whoever takes it, remove the other flags if you could please :)
Attachment #594418 - Flags: review?(doug.turner)
Attachment #594418 - Flags: review?(blassey.bugs)
(Assignee)

Comment 2

5 years ago
Created attachment 594420 [details] [diff] [review]
Backout ondemand tiling

And correct the commit message.
Attachment #594418 - Attachment is obsolete: true
Attachment #594418 - Flags: review?(doug.turner)
Attachment #594418 - Flags: review?(blassey.bugs)
Attachment #594420 - Flags: review?(doug.turner)
Attachment #594420 - Flags: review?(blassey.bugs)
(Assignee)

Comment 3

5 years ago
Try run: http://tbpl.mozilla.org/?tree=Try&rev=7fa0d3a0e995
Comment on attachment 594420 [details] [diff] [review]
Backout ondemand tiling

Review of attachment 594420 [details] [diff] [review]:
-----------------------------------------------------------------

pretty rubbery-stampy r+
Attachment #594420 - Flags: review?(blassey.bugs) → review+
Comment on attachment 594420 [details] [diff] [review]
Backout ondemand tiling

Lots of stuff here but I looked over it and there doesn't appear to be anything obviously wrong with it. Try run is also green, and I built it locally and it seems to work fine.
Attachment #594420 - Flags: review?(doug.turner) → review+
Duplicate of this bug: 724042
Landed on inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/f9eb58a6dd6a

Comment 8

5 years ago
https://hg.mozilla.org/mozilla-central/rev/f9eb58a6dd6a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Comment on attachment 594420 [details] [diff] [review]
Backout ondemand tiling

[Triage Comment]
This is needed on aurora, but not beta. The code never landed there.

This backout should make the rendering performance on aurora match that on trunk and beta.
Attachment #594420 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/784efd5bfec0
status-firefox11: --- → unaffected
status-firefox12: --- → fixed
status-firefox13: --- → fixed
You need to log in before you can comment on or make changes to this bug.