Closed Bug 724468 Opened 12 years ago Closed 12 years ago

HTML5 Extension for Windows Media Player Plug-in 1.0 Causing Memory Leak

Categories

(WebExtensions :: General, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: randall, Assigned: kinger)

References

Details

(Whiteboard: [MemShrink:P2][3rd-party-bustage])

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0) Gecko/20100101 Firefox/10.0
Build ID: 20120129021758

Steps to reproduce:

Apparently the HTML5 extension updated itself to compatibility and re-enabled itself. I took no direct action regarding installing or enabling this plugin.


Actual results:

Memory leaked all over the place. Rolled up to 1.4G RAM usage. GC/CC/Minimize Memory Usage has no effect on it. Disabling the plugin immediately cut RAM usage back down to normal levels (about 600-700MB freed up instantly)


Expected results:

No memory leak.
Please provide a link to the extension that caused this.
Blocks: LeakyAddons
Whiteboard: [MemShrink]
Whiteboard: [MemShrink] → [MemShrink][3rd-party-busgage]
Kev, do you know anyone at Microsoft who works on this?
Whiteboard: [MemShrink][3rd-party-busgage] → [MemShrink:P2]
Whiteboard: [MemShrink:P2] → [MemShrink:P2][3rd-party-bustage]
Component: Untriaged → Add-ons
Product: Firefox → Tech Evangelism
Version: 10 Branch → unspecified
I tried their contact form and another add-on developer at MS (probably unrelated to this extension). If there is no response in the next week or so, we need to poke Kev again about this.
I'll take this!

I suspect *some* of the leakage is the fact that an old version of the SDK is being used.
Assignee: nobody → briks.si
Status: UNCONFIRMED → NEW
Ever confirmed: true
Oh, right, I forgot you had worked on this. Thanks, Brian!

And yes, version 1.6 of the SDK is the only one with no known leaks. Judging by the severity of the report, though, I suspect there's more to it.

I also received a very encouraging response from the Microsoft dev (Claudio Caldato).
Reporter (or anyone else),

Please check this version and let me know how it behaves WRT memory:

http://dl.dropbox.com/u/5940796/ms/wmpff-1.1b1.xpi

I have not run it through any tools yet, but in my casual testing there was no noticeable different with it installed or not.

This is using version 1.6 of the SDK.
Status: NEW → ASSIGNED
Randall, Andrew: can you give this new version a try?
I don't see any increase in memory usage with this new version of the addon installed.  Though I couldn't actually get the add-on to demonstrably work on a test page if that makes a difference.
(In reply to Andrew Williamson [:eviljeff] from comment #9)
> I don't see any increase in memory usage with this new version of the addon
> installed.  Though I couldn't actually get the add-on to demonstrably work
> on a test page if that makes a difference.

What page(s) did you test with?
(In reply to Brian King (Briks) [:kinger] from comment #10)
> (In reply to Andrew Williamson [:eviljeff] from comment #9)
> > I don't see any increase in memory usage with this new version of the addon
> > installed.  Though I couldn't actually get the add-on to demonstrably work
> > on a test page if that makes a difference.
> 
> What page(s) did you test with?

http://www.vdat.com/techsupport/PRNwindowstest.asp - it appeared to load but pressing the play button in the toolbar didn't play anything iirc.
Brian: what's the status of this new version? Has it been released? Do we have confirmation that is works correctly?
(In reply to Andrew Williamson [:eviljeff] from comment #11)
> http://www.vdat.com/techsupport/PRNwindowstest.asp - it appeared to load but
> pressing the play button in the toolbar didn't play anything iirc.

What version of Windows? WFM on Win7.
(In reply to Jorge Villalobos [:jorgev] from comment #12)
> Brian: what's the status of this new version? Has it been released? Do we
> have confirmation that is works correctly?

This was released yesterday and is being updated via the update channel. The version is 1.1. It was built with version 1.6.1 of the SDK.

Direct link:
http://www.interoperabilitybridges.com/wmpff/wmpff.xpi

The install page needs updating to point to the correct XPI, but that should be fixed today.
(In reply to Brian King (Briks) [:kinger] from comment #13)
> (In reply to Andrew Williamson [:eviljeff] from comment #11)
> > http://www.vdat.com/techsupport/PRNwindowstest.asp - it appeared to load but
> > pressing the play button in the toolbar didn't play anything iirc.
> 
> What version of Windows? WFM on Win7.

Win7. Anything involving WMP and codecs could be broken on my computer due to any number of reasons though.
I see it now on one profile on Win Vista. But this is a plugin issue, separate to what the extension does, and unrelated to this bug. I'll make sure the MS folks are aware of it.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
i'll give it a run through one of my sessions, trouble with this plugin was that it grew considerably while idle and not so noticeably while actually browsing.
Also, http://www.vdat.com/techsupport/PRNwindowstest.asp is not a test that is affected by the h264 video plugin, the np-mswmp.dll is used whether the h264 wrapper is installed or not.
I cannot find any test pages which use this extension at all

the tests at quirksmode.org don't seem to work with it :3
ok, now works on quirksmode.org, previous broken-ness was probably a result of bug 751641

requires the msmpeg2adec and msmpeg2vdec files that come as part of Windows 7 DMO unfortunately, which i disable in favour of other codecs
Component: Add-ons → General
Product: Tech Evangelism → WebExtensions
You need to log in before you can comment on or make changes to this bug.