724532 - Crash @ nsJSNPRuntime::OnPluginDestroy with RealPlayer plugin

Status: RESOLVED WORKSFORME

(Core Graveyard :: Plug-ins, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, steps to reproduce:
- Load testcase, click on the volume control of the RealPlayer plugin.
- Wait for the page to reload

This regressed when bug 90268 was fixed.

From about:plugins:
RealPlayer Version Plugin

    File: nprpjplug.dll
    Version: 15.0.1.13
    15.0.1.13

https://crash-stats.mozilla.com/report/index/bp-95d5511e-f6f3-4d72-90bd-19f942120206
0 	msvcr100.dll 	msvcr100.dll@0x8af06 	
1 	xul.dll 	nsJSNPRuntime::OnPluginDestroy 	dom/plugins/base/nsJSNPRuntime.cpp:2027
2 	xul.dll 	mozilla::plugins::PPluginInstanceParent::Call__delete__ 	obj-firefox/ipc/ipdl/PPluginInstanceParent.cpp:221
3 	xul.dll 	mozilla::plugins::PPluginInstanceParent::Call__delete__ 	obj-firefox/ipc/ipdl/PPluginInstanceParent.cpp:222
4 	nspr4.dll 	_PR_MD_UNLOCK 	nsprpub/pr/src/md/windows/w95cv.c:344
5 	nspr4.dll 	PR_LogFlush 	nsprpub/pr/src/io/prlog.c:566
6 	xul.dll 	nsNPAPIPluginInstance::Stop 	dom/plugins/base/nsNPAPIPluginInstance.cpp:237

Comment 1

[John Schoenick [:johns]]

Does this still occur? The RealPlayer plugin on windows is the only case where we use the delayed-stop codepath currently, so we're likely lacking test coverage there :(

Comment 2

[Martijn Wargers (dead)]

I didn't have the RealPlayer installed anymore.
Using the plugin finder service in Firefox is pretty dreadful. It's going to download RealPlayer 15 and at the end of that it says it failed to install it, saying I have to manually install it.

Comment 3

[Martijn Wargers (dead)]

The issue itself seems fixed with REalPlayer 16.0.1.18.