Closed Bug 711953 Opened 9 years ago Closed 7 years ago

[skiplist] Add msvcr.*\.dll.* to prefixSignatureRegEx

Categories

(Socorro :: Infra, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: scoobidiver, Unassigned)

References

Details

(Whiteboard: [needs feedback from developers][qa-])

Please add:
'msvcr80.dll@0x.*'
'msvcr90.dll@0x.*'
'msvcrt.dll@0x.*'
to the skiplist as irrelevantSignatureRegEx
Not sure if we really want to hide when something happens inside the C libraries. Is libc.so also on the irrelevant list?
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #1)
> Is libc.so also on the irrelevant list?
Yes. See https://github.com/mozilla/socorro/blob/master/scripts/config/processorconfig.py.dist
Component: Socorro → General
Product: Webtools → Socorro
Component: General → Infra
Blocks: 718192
If this bug was fixed, bug 718192 could have been discovered before.
Blocks: 718949
Blocks: 719723
Add also:
'msvcr100.dll@0x.*'
Blocks: 724532
I propose we add msvcr.*\.dll.* to prefixSignatureRegEx here - Ted, Benjamin, does that sound reasonable, or would a different step be good here?
Summary: Add msvcr* DLLs to the skiplist as irrelevantSignatureRegEx → [skiplist] Add msvcr.*\.dll.* to prefixSignatureRegEx
Whiteboard: [needs feedback from developers]
Kyle knows about Windows, maybe he has some idea.
We should be getting symbols for these. They don't change that often, so I don't think we should skiplist them. We did have a bug where Windows system symbols weren't being updated, but that ought to be fixed now.
(In reply to Ted Mielczarek [:ted] from comment #7)
> We should be getting symbols for these. They don't change that often, so I
> don't think we should skiplist them. We did have a bug where Windows system
> symbols weren't being updated, but that ought to be fixed now.

Well, we still get enough reports in with those frames as "signatures".
Kyle, Ted, what should we be doing here?
We added libc.so even to irrelevantSignatureRegEx, see https://github.com/mozilla/socorro/blob/master/scripts/config/processorconfig.py.dist#L134
I don't have a problem with ignoring them if we legitimately don't have symbols for them, but comment 7 claims we should ...
Blocks: 749928, 745676, 719109
Blocks: 795728, 795940
Whiteboard: [needs feedback from developers] → [needs feedback from developers][qa-]
Blocks: 803194
Blocks: 859099
Blocks: 860149
Blocks: 879354
Blocks: 888614
In blocking bugs, two are classified as top crashers: bug 879354 and bug 888614.

Whatever the reason of missing debug symbols, implementing the skiplist will help breakdown this unique signature and see whether they are really top crashers to take care of.
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #7)
> We should be getting symbols for these.
Unless it's a MS Visual C++ Redistributable DLL that comes bundled with the faulty program such as Flash or Whitesky's ID Vault.
Flags: needinfo?(ted)
Shouldn't matter, we should be able to get symbols for those from Microsoft's symbol server. The redistributable DLLs are still built by Microsoft.
Flags: needinfo?(ted)
FWIW, there is a problem specifically with either the symbols or our stackwalking for the pure-virtual handler; when I load bug 888614 minidumps in Visual Studio you can see that the crash is in that function, but somehow that information is not translated to breakpad. I'll investigate that, but I think overall this should be WONTFIX.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.