Queue folder deletions, processing them after other records

VERIFIED FIXED in mozilla14

Status

()

Firefox for Android
Android Sync
P2
normal
VERIFIED FIXED
6 years ago
a month ago

People

(Reporter: rnewman, Assigned: rnewman)

Tracking

unspecified
mozilla14
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking-fennec1.0 beta+)

Details

(Assignee)

Description

6 years ago
When a folder deletion is handled, we must ensure -- for database consistency -- that its children are placed somewhere sane.

Its children might also be deleted, but we'll process folders first. To avoid having to move a whole bunch of children, then delete them, we want to queue up folder deletions and take care of them in one go.
(Assignee)

Updated

6 years ago
Depends on: 724740
(Assignee)

Updated

6 years ago
Assignee: nobody → rnewman
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

6 years ago
Depends on: 744282
(Assignee)

Comment 1

6 years ago
Merged branch, waiting for testing:

https://github.com/mozilla-services/android-sync/pull/154
(Assignee)

Comment 2

6 years ago
Tested by hand, including deleting just a folder on the server. Orphaning works as expected.

https://hg.mozilla.org/integration/mozilla-inbound/rev/5633c5648fed
https://hg.mozilla.org/integration/mozilla-inbound/rev/6124a190cc2b
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c2a06f36ba3
https://hg.mozilla.org/integration/mozilla-inbound/rev/3aef4f7cbd6d
https://hg.mozilla.org/integration/mozilla-inbound/rev/6cb5a238e20d
Target Milestone: --- → mozilla14

Updated

6 years ago
blocking-fennec1.0: --- → ?
this one looks good.
blocking-fennec1.0: ? → beta+

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/5633c5648fed
https://hg.mozilla.org/mozilla-central/rev/6124a190cc2b
https://hg.mozilla.org/mozilla-central/rev/1c2a06f36ba3
https://hg.mozilla.org/mozilla-central/rev/3aef4f7cbd6d
https://hg.mozilla.org/mozilla-central/rev/6cb5a238e20d
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Status: RESOLVED → VERIFIED
Component: Android Sync → Android Sync
Product: Mozilla Services → Android Background Services

Updated

a month ago
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.