724739 - Queue folder deletions, processing them after other records

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Android Sync, defect, P2)

Description

[Richard Newman [:rnewman]]

When a folder deletion is handled, we must ensure -- for database consistency -- that its children are placed somewhere sane.

Its children might also be deleted, but we'll process folders first. To avoid having to move a whole bunch of children, then delete them, we want to queue up folder deletions and take care of them in one go.

Comment 1

[Richard Newman [:rnewman]]

Merged branch, waiting for testing:

https://github.com/mozilla-services/android-sync/pull/154

Comment 2

[Richard Newman [:rnewman]]

Tested by hand, including deleting just a folder on the server. Orphaning works as expected.

https://hg.mozilla.org/integration/mozilla-inbound/rev/5633c5648fed
https://hg.mozilla.org/integration/mozilla-inbound/rev/6124a190cc2b
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c2a06f36ba3
https://hg.mozilla.org/integration/mozilla-inbound/rev/3aef4f7cbd6d
https://hg.mozilla.org/integration/mozilla-inbound/rev/6cb5a238e20d

Comment 3

[Tracy Walker [:tracy]]

this one looks good.

Comment 4

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/5633c5648fed
https://hg.mozilla.org/mozilla-central/rev/6124a190cc2b
https://hg.mozilla.org/mozilla-central/rev/1c2a06f36ba3
https://hg.mozilla.org/mozilla-central/rev/3aef4f7cbd6d
https://hg.mozilla.org/mozilla-central/rev/6cb5a238e20d