724805 - Bug 723126 broke PlacesDBUtils add-ons compatibility

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Alice0775 White]

"Places Maintenance" stops working


Reproducible: Always

Steps to Reproduce:
1. Install "Places Maintenance" https://addons.mozilla.org/en-US/firefox/addon/places-maintenance/
2. Open Add-ons Manager (Ctrl+Shift+A)
3. Click "Option" of "Places Maintenance"
4. Check any checkbox and Execute

Actual Results:
The execution is not finished properly.

Regression window:
Works:
http://hg.mozilla.org/integration/mozilla-inbound/rev/6b00b520b304
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0a1) Gecko/20120203 Firefox/13.0a1 ID:20120204055904
Fails:
http://hg.mozilla.org/integration/mozilla-inbound/rev/a31efbfbba7b
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0a1) Gecko/20120204 Firefox/13.0a1 ID:20120204061403
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6b00b520b304&tochange=a31efbfbba7b

Comment 1

[Marco Bonardo [:mak]]

thanks, I'll check what's up.

Comment 2

[Marco Bonardo [:mak]]

Attachment: patch v1.0

This restores compatibility as it was before, and adds a new method to use tasks more correctly.
Once in Nightly I'll submit an add-on update to use the new method in newer versions, that I have ready.

Comment 3

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9422dadbfc7b

Comment 4

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/9422dadbfc7b