Closed
Bug 723126
Opened 12 years ago
Closed 12 years ago
Telemetry for time needed for idle maintenance
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: mak, Assigned: mak)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
6.38 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
We don't have a good idea of how much maintenance may take in the wild. It happens on idle but may still be an heavy task disrupting video streaming and such.
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #593863 -
Flags: review?(dietrich)
Comment 2•12 years ago
|
||
Comment on attachment 593863 [details] [diff] [review] patch v1.0 Review of attachment 593863 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/places/PlacesDBUtils.jsm @@ +90,5 @@ > else { > + // All tasks have been completed. > + // Telemetry the time it took for maintenance, if a start time exists. > + if (aTasks.telemetryStart) { > + try { remove the try/catch, unnecessary. @@ +92,5 @@ > + // Telemetry the time it took for maintenance, if a start time exists. > + if (aTasks.telemetryStart) { > + try { > + Services.telemetry.getHistogramById("PLACES_IDLE_MAINTENANCE_TIME_MS") > + .add(Date.now() - aTasks.telemetryStart); should clear the telemetryStart value. @@ +138,5 @@ > this.checkIntegrity > , this.checkCoherence > , this._refreshUI > ]); > + tasks.telemetryStart = Date.now(); please add underscore since it's fake-private. here and elsewhere.
Attachment #593863 -
Flags: review?(dietrich) → review+
Assignee | ||
Comment 3•12 years ago
|
||
with fixed comments https://hg.mozilla.org/integration/mozilla-inbound/rev/a31efbfbba7b
Target Milestone: --- → mozilla13
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a31efbfbba7b
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•