724808 - First run import wizard doesn't show up on Firefox 12 and 13

Status: VERIFIED FIXED

(Firefox :: Migration, defect)

Description

[Paul Silaghi, QA [:pauly]]

Steps to reproduce:
1. Install Firefox 12 (Aurora) and Firefox 13 (Nightly)
2. Remove profiles folders:
On Windows - %appdata%\Mozilla
On Mac - Library\Application Support\Firefox
On Linux - /home/user/.mozilla
3. Start Aurora or Nighly

Expected results:
First run import wizard should show up

Actual results:
No import wizard displayed

Note:
Import wizard shows up on FF 11b1

Comment 1

[u279076]

I confirm that the First Run migration wizard displayed on 11.0a2 so it seems that it is a recent change the made Aurora/Nightly not display it.

Paul, can you please track down a regression range?

Comment 2

[Paul Silaghi, QA [:pauly]]

Last good nightly: 2012-01-16
First bad nightly: 2012-01-17
http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2012-01-16&enddate=2012-01-17

I suspect bug 715099, but I'm not really sure.

Comment 3

[u279076]

Thanks Paul. Yeah, bug 715099 seems like it could be a likely culprit.

Comment 4

[Marco Bonardo [:mak]]

tentatively assigning to Mano, though if anyone else has a fix feel free to steal.

Comment 5

[Makoto Kato [:m_kato]]

maybe, let pathMatches = value.match(/^"?(.+?\.exe)"?/); is invalid.  I don't think that this can extract program filename.

Comment 6

[Matthew N. [:MattN]]

Paul/Anthony, were there any errors in the error console after the first-run startup?

Comment 7

[Paul Silaghi, QA [:pauly]]

There are no errors, only some warnings.

Comment 8

[Asaf Romano (gone)]

Looking now.

Comment 9

[Asaf Romano (gone)]

Attachment: aham

After trying hard to reproduce it with my debug build... I figure what it's missing. I haven't tested this though (that is, I haven't built the installer).

Comment 10

[Marco Bonardo [:mak]]

Comment on attachment 596463 [details] [diff] [review]
aham

Review of attachment 596463 [details] [diff] [review]:
-----------------------------------------------------------------

made an installer locally without and with the patch, tried starting the browser without a mozilla userdata folder and verified it opens the dialog after the patch, not before.

Comment 11

[Asaf Romano (gone)]

Comment on attachment 596463 [details] [diff] [review]
aham

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:

Comment 12

[Asaf Romano (gone)]

Comment on attachment 596463 [details] [diff] [review]
aham

oops!

Comment 13

[Marco Bonardo [:mak]]

can this land please?

Comment 14

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f0cc27e3731c

Comment 15

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f0cc27e3731c

Comment 16

[Paul Silaghi, QA [:pauly]]

First run import wizard is now displayed on FF 13 but without the Home Page Selection screen as in FF 11.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120304 Firefox/13.0a1

Comment 17

[Marco Bonardo [:mak]]

Comment on attachment 596463 [details] [diff] [review]
aham

[Approval Request Comment]
Regression caused by (bug #): bug 715099
User impact if declined: no first run migration
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): low, adding a missing file to the package
String changes made by this patch: none

Comment 18

[Marco Bonardo [:mak]]

(In reply to Paul Silaghi [QA] from comment #16)
> First run import wizard is now displayed on FF 13 but without the Home Page
> Selection screen as in FF 11.

please file a bug in Firefox/Migration about this so we can evaluate if it's expected or not, specify platform and the source browser.

Comment 19

[Alex Keybl [:akeybl]]

Comment on attachment 596463 [details] [diff] [review]
aham

[Triage Comment]
Low risk - approved for Aurora 12.

Comment 20

[Marco Bonardo [:mak]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b85d46219b00

Comment 21

[Paul Silaghi, QA [:pauly]]

(In reply to Marco Bonardo [:mak] from comment #18)
> please file a bug in Firefox/Migration about this so we can evaluate if it's
> expected or not, specify platform and the source browser.

New bug 735183 filed. Marking this bug as verified fixed.