Closed Bug 724808 Opened 8 years ago Closed 8 years ago

First run import wizard doesn't show up on Firefox 12 and 13

Categories

(Firefox :: Migration, defect)

12 Branch
x86
All
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 13
Tracking Status
firefox12 + verified

People

(Reporter: pauly, Assigned: mano)

References

Details

(Keywords: regression)

Attachments

(1 file)

Steps to reproduce:
1. Install Firefox 12 (Aurora) and Firefox 13 (Nightly)
2. Remove profiles folders:
On Windows - %appdata%\Mozilla
On Mac - Library\Application Support\Firefox
On Linux - /home/user/.mozilla
3. Start Aurora or Nighly

Expected results:
First run import wizard should show up

Actual results:
No import wizard displayed

Note:
Import wizard shows up on FF 11b1
I confirm that the First Run migration wizard displayed on 11.0a2 so it seems that it is a recent change the made Aurora/Nightly not display it.

Paul, can you please track down a regression range?
Last good nightly: 2012-01-16
First bad nightly: 2012-01-17
http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2012-01-16&enddate=2012-01-17

I suspect bug 715099, but I'm not really sure.
Thanks Paul. Yeah, bug 715099 seems like it could be a likely culprit.
tentatively assigning to Mano, though if anyone else has a fix feel free to steal.
Assignee: nobody → mano
Status: NEW → ASSIGNED
Blocks: 715099
maybe, let pathMatches = value.match(/^"?(.+?\.exe)"?/); is invalid.  I don't think that this can extract program filename.
Paul/Anthony, were there any errors in the error console after the first-run startup?
There are no errors, only some warnings.
Attached patch ahamSplinter Review
After trying hard to reproduce it with my debug build... I figure what it's missing. I haven't tested this though (that is, I haven't built the installer).
Attachment #596463 - Flags: review?(mak77)
Comment on attachment 596463 [details] [diff] [review]
aham

Review of attachment 596463 [details] [diff] [review]:
-----------------------------------------------------------------

made an installer locally without and with the patch, tried starting the browser without a mozilla userdata folder and verified it opens the dialog after the patch, not before.
Attachment #596463 - Flags: review?(mak77) → review+
Comment on attachment 596463 [details] [diff] [review]
aham

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:
Attachment #596463 - Flags: approval-mozilla-aurora?
can this land please?
https://hg.mozilla.org/mozilla-central/rev/f0cc27e3731c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Flags: in-testsuite?
Flags: in-litmus?
First run import wizard is now displayed on FF 13 but without the Home Page Selection screen as in FF 11.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120304 Firefox/13.0a1
Comment on attachment 596463 [details] [diff] [review]
aham

[Approval Request Comment]
Regression caused by (bug #): bug 715099
User impact if declined: no first run migration
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): low, adding a missing file to the package
String changes made by this patch: none
Attachment #596463 - Flags: approval-mozilla-aurora?
(In reply to Paul Silaghi [QA] from comment #16)
> First run import wizard is now displayed on FF 13 but without the Home Page
> Selection screen as in FF 11.

please file a bug in Firefox/Migration about this so we can evaluate if it's expected or not, specify platform and the source browser.
Comment on attachment 596463 [details] [diff] [review]
aham

[Triage Comment]
Low risk - approved for Aurora 12.
Attachment #596463 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(In reply to Marco Bonardo [:mak] from comment #18)
> please file a bug in Firefox/Migration about this so we can evaluate if it's
> expected or not, specify platform and the source browser.

New bug 735183 filed. Marking this bug as verified fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.