Last Comment Bug 724873 - Don't include nsString.h in nsIXPathEvaluatorInternal.h
: Don't include nsString.h in nsIXPathEvaluatorInternal.h
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla13
Assigned To: Philipp Wagner [:imphil]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-07 07:02 PST by Philipp Wagner [:imphil]
Modified: 2012-02-09 10:15 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (990 bytes, patch)
2012-02-07 07:02 PST, Philipp Wagner [:imphil]
benjamin: review+
Details | Diff | Review
patch for checkin; r=bsmedberg (1.55 KB, patch)
2012-02-08 09:29 PST, Philipp Wagner [:imphil]
no flags Details | Diff | Review
patch for checkin; r=bsmedberg (907 bytes, patch)
2012-02-08 09:32 PST, Philipp Wagner [:imphil]
no flags Details | Diff | Review

Description Philipp Wagner [:imphil] 2012-02-07 07:02:26 PST
Created attachment 595024 [details] [diff] [review]
patch

XForms includes this file and it's using the external string API. This was introduced with bug 693949.
Comment 1 Benjamin Smedberg [:bsmedberg] 2012-02-08 09:22:33 PST
Comment on attachment 595024 [details] [diff] [review]
patch

This seems silly, but ok.
Comment 2 Philipp Wagner [:imphil] 2012-02-08 09:29:21 PST
Created attachment 595434 [details] [diff] [review]
patch for checkin; r=bsmedberg

could someone check this in for me, please?
Comment 3 Philipp Wagner [:imphil] 2012-02-08 09:32:35 PST
Created attachment 595436 [details] [diff] [review]
patch for checkin; r=bsmedberg

uh, the other change should have not been part of this patch.
Comment 5 Ed Morley [:emorley] 2012-02-09 10:15:23 PST
https://hg.mozilla.org/mozilla-central/rev/abcf47b9300d

Note You need to log in before you can comment on or make changes to this bug.