disk cache needs efficient eviction and miss detection

RESOLVED FIXED in mozilla0.9

Status

()

Core
Networking: Cache
P1
normal
RESOLVED FIXED
17 years ago
17 years ago

People

(Reporter: gordon, Assigned: gordon)

Tracking

Trunk
mozilla0.9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [cache])

(Assignee)

Description

17 years ago
This will be fixed by implementing the disk cache record table.
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Whiteboard: [cache]
(Assignee)

Updated

17 years ago
Target Milestone: --- → mozilla0.9
(Assignee)

Updated

17 years ago
Priority: -- → P1
(Assignee)

Updated

17 years ago
Blocks: 68705

Comment 1

17 years ago
one major problem and a few nits:


nsCache.cpp:
 * unused #if defined(PR_LOGGING) at top of file
 * what if CacheLogInit() were called twice?

nsCacheEntryDescriptor.cpp:
 * you can remove redundant checking of |visitor| parameter

nsCacheService.cpp:
 * might want to clean up tabbing on line 773
 * might want to clean up tabbing on line 779
 * nsCacheService::Shutdown() calls LogCacheStatistics() outside of #ifdef

nsMemoryCacheDevice.cpp:
 * nsCRT::strlen(0) returns 0, so you can remove the redundant check

Comment 2

17 years ago
my comments apply to the DISKCACHE1_BRANCH as of 4/3/2001 17:40:05 PDT

Comment 3

17 years ago
sr=darin once the non- PR_LOGGING shutdown problem is fixed.
(Assignee)

Comment 4

17 years ago
I've fixed all these except the redundant visitor check on the branch.  I'll land 
it as soon as the trees go green.
(Assignee)

Comment 5

17 years ago
DISKCACHE1_BRANCH has landed.  Marking FIXED.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.