Add internal observer notification for last PB docshell going away

RESOLVED FIXED in mozilla14

Status

()

Core
Document Navigation
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: jdm, Assigned: jdm)

Tracking

unspecified
mozilla14
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 595318 [details] [diff] [review]
<required>
Attachment #595318 - Flags: review?(bzbarsky)
(Assignee)

Comment 2

6 years ago
Created attachment 595319 [details] [diff] [review]
Add observer notification for last PB docshell going away.
Attachment #595319 - Flags: review?(bzbarsky)
(Assignee)

Updated

6 years ago
Attachment #595318 - Attachment is obsolete: true
Attachment #595318 - Flags: review?(bzbarsky)
(Assignee)

Updated

6 years ago
Assignee: nobody → josh
Blocks: 463027, 722845
(Assignee)

Updated

6 years ago
Blocks: 722859
Comment on attachment 595319 [details] [diff] [review]
Add observer notification for last PB docshell going away.

Seems ok, but do you need to stabilize the count around going back to session restored stuff, so that we don't end up bouncing off zero for the subframes?
Attachment #595319 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/01259925085c

I added an assert to the function to be safe, but I think the counting should be ok.
(Assignee)

Comment 5

6 years ago
Backed out https://hg.mozilla.org/integration/mozilla-inbound/rev/d6b8a8bedb49.
(Assignee)

Updated

6 years ago
Blocks: 722850
(Assignee)

Updated

6 years ago
Blocks: 722981
(Assignee)

Comment 6

6 years ago
Created attachment 599472 [details] [diff] [review]
Add observer notification for last PB docshell going away.
(Assignee)

Updated

6 years ago
Attachment #595319 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Whiteboard: [needs landing]
(Assignee)

Updated

6 years ago
Blocks: 722857
Can this land, Josh?
(Assignee)

Comment 8

6 years ago
Yes, I just haven't got around to it.
(Assignee)

Updated

6 years ago
Blocks: 722861
(Assignee)

Updated

6 years ago
Blocks: 722868
https://hg.mozilla.org/integration/mozilla-inbound/rev/9065e98ffb5d
Whiteboard: [needs landing]
Target Milestone: --- → mozilla14
Created attachment 611548 [details] [diff] [review]
Test case
Attachment #611548 - Flags: review?(josh)
(Assignee)

Comment 11

6 years ago
I don't think the whole window close + gc dance should be necessary; this is meant to fire after the last docshell leaves private mode. Why doesn't setting the privateWindow flag to false trigger it?
Because the value is decremented when the docshell gets destroyed, and that happens only when a CC is run after the window has been closed.

Do you have any better suggestions?
(Assignee)

Comment 13

6 years ago
Comment on attachment 611548 [details] [diff] [review]
Test case

It makes me sad that this is necessary, but ok.
Attachment #611548 - Flags: review?(josh) → review+
https://hg.mozilla.org/mozilla-central/rev/9065e98ffb5d

leaving open for the test
https://hg.mozilla.org/integration/mozilla-inbound/rev/ccb232b6b97a
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/ccb232b6b97a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Blocks: 722979
Blocks: 730840
You need to log in before you can comment on or make changes to this bug.