Closed Bug 725210 Opened 12 years ago Closed 12 years ago
Add internal observer notification for last PB docshell going away
No description provided.
Comment on attachment 595319 [details] [diff] [review] Add observer notification for last PB docshell going away. Seems ok, but do you need to stabilize the count around going back to session restored stuff, so that we don't end up bouncing off zero for the subframes?
Attachment #595319 - Flags: review?(bzbarsky) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/01259925085c I added an assert to the function to be safe, but I think the counting should be ok.
Attachment #595319 - Attachment is obsolete: true
Can this land, Josh?
Yes, I just haven't got around to it.
Whiteboard: [needs landing]
Target Milestone: --- → mozilla14
I don't think the whole window close + gc dance should be necessary; this is meant to fire after the last docshell leaves private mode. Why doesn't setting the privateWindow flag to false trigger it?
Because the value is decremented when the docshell gets destroyed, and that happens only when a CC is run after the window has been closed. Do you have any better suggestions?
Comment on attachment 611548 [details] [diff] [review] Test case It makes me sad that this is necessary, but ok.
Attachment #611548 - Flags: review?(josh) → review+
https://hg.mozilla.org/mozilla-central/rev/9065e98ffb5d leaving open for the test
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.