Closed Bug 730840 Opened 10 years ago Closed 9 years ago

Use getBrowserURL() in Firefox tests to ease porting them, part 2

Categories

(Firefox :: General, defect)

defect
Not set
minor

Tracking

()

VERIFIED FIXED
Firefox 15

People

(Reporter: sgautherie, Assigned: raymondlee)

References

()

Details

Attachments

(1 file, 2 obsolete files)

+++ This bug was initially created as a clone of Bug #717963 +++

"Found 4 matching lines in 3 files"
Attached patch v1 (obsolete) — Splinter Review
Updated to use getBrowserURL in browser tests.
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #618578 - Flags: review?(dao)
Comment on attachment 618578 [details] [diff] [review]
v1

Could you fix new

/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_lastpbcontextexited.js
    * line 40 -- let newWin = window.openDialog("chrome://browser/content/", "_blank", "chrome,all,dialog=no");

too?
Attachment #618578 - Flags: feedback+
Depends on: 725210
Attached patch v2 (obsolete) — Splinter Review
(In reply to Serge Gautherie (:sgautherie) from comment #2)
> Comment on attachment 618578 [details] [diff] [review]
> v1
> 
> Could you fix new
> 
> /browser/components/privatebrowsing/test/browser/
> browser_privatebrowsing_lastpbcontextexited.js
>     * line 40 -- let newWin = window.openDialog("chrome://browser/content/",
> "_blank", "chrome,all,dialog=no");
> 
> too?

Done.
Attachment #618578 - Attachment is obsolete: true
Attachment #618595 - Flags: review?(dao)
Attachment #618578 - Flags: review?(dao)
Attachment #618595 - Flags: feedback+
Attachment #618595 - Flags: review?(dao) → review+
Attachment #618595 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4f72e3b1081
Flags: in-testsuite+
Keywords: checkin-needed
Target Milestone: --- → Firefox 15
http://hg.mozilla.org/mozilla-central/rev/e4f72e3b1081
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
V.Fixed, per MXR search.
Status: RESOLVED → VERIFIED
Whiteboard: [good first bug][mentor=sgautherie][lang=js]
You need to log in before you can comment on or make changes to this bug.