Use getBrowserURL() in Firefox tests to ease porting them, part 2

VERIFIED FIXED in Firefox 15

Status

()

Firefox
General
--
minor
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: sgautherie, Assigned: raymondlee)

Tracking

Trunk
Firefox 15
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

6 years ago
+++ This bug was initially created as a clone of Bug #717963 +++

"Found 4 matching lines in 3 files"
(Reporter)

Updated

6 years ago
(Assignee)

Comment 1

5 years ago
Created attachment 618578 [details] [diff] [review]
v1

Updated to use getBrowserURL in browser tests.
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #618578 - Flags: review?(dao)
(Reporter)

Comment 2

5 years ago
Comment on attachment 618578 [details] [diff] [review]
v1

Could you fix new

/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_lastpbcontextexited.js
    * line 40 -- let newWin = window.openDialog("chrome://browser/content/", "_blank", "chrome,all,dialog=no");

too?
Attachment #618578 - Flags: feedback+
(Reporter)

Updated

5 years ago
Depends on: 725210
(Assignee)

Comment 3

5 years ago
Created attachment 618595 [details] [diff] [review]
v2

(In reply to Serge Gautherie (:sgautherie) from comment #2)
> Comment on attachment 618578 [details] [diff] [review]
> v1
> 
> Could you fix new
> 
> /browser/components/privatebrowsing/test/browser/
> browser_privatebrowsing_lastpbcontextexited.js
>     * line 40 -- let newWin = window.openDialog("chrome://browser/content/",
> "_blank", "chrome,all,dialog=no");
> 
> too?

Done.
Attachment #618578 - Attachment is obsolete: true
Attachment #618595 - Flags: review?(dao)
Attachment #618578 - Flags: review?(dao)
(Reporter)

Updated

5 years ago
Attachment #618595 - Flags: feedback+

Updated

5 years ago
Attachment #618595 - Flags: review?(dao) → review+
(Assignee)

Comment 4

5 years ago
Created attachment 618949 [details] [diff] [review]
Patch for checkin
Attachment #618595 - Attachment is obsolete: true
(Assignee)

Comment 5

5 years ago
Comment on attachment 618949 [details] [diff] [review]
Patch for checkin

Passed Try
https://tbpl.mozilla.org/?tree=Try&rev=ef5f8d617329
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4f72e3b1081
Flags: in-testsuite+
Keywords: checkin-needed
Target Milestone: --- → Firefox 15
http://hg.mozilla.org/mozilla-central/rev/e4f72e3b1081
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Comment 8

5 years ago
V.Fixed, per MXR search.
Status: RESOLVED → VERIFIED
Whiteboard: [good first bug][mentor=sgautherie][lang=js]
You need to log in before you can comment on or make changes to this bug.